commit 893988e6bea496363758e74293c08c5e1068cd0c
author Daniele Moro <daniele@opennetworking.org> Wed Nov 27 16:14:38 2019 -0800
committer Carmelo Cascone <carmelo@opennetworking.org> Mon Dec 02 23:41:13 2019 +0000
tree 9fbd8e16c63f0fdbd1534146bb438d78ea4307b8
parent 91f3cb61797a37c40ecbee8da12266df7eaceee8

Update to BngProgrammable API

Setup of an attachment won't trigger counters clean up

Change-Id: I6be72bdedb71bbc6152e8192ec4614a2f812b014
(cherry picked from commit e12d0ea7f3a7590a30c282294e83f7978bda914b)

core/api/src/main/java/org/onosproject/net/behaviour/BngProgrammable.java

diff --git a/core/api/src/main/java/org/onosproject/net/behaviour/BngProgrammable.java b/core/api/src/main/java/org/onosproject/net/behaviour/BngProgrammable.java
index a35377e..3f6f9e9 100644
--- a/core/api/src/main/java/org/onosproject/net/behaviour/BngProgrammable.java
+++ b/core/api/src/main/java/org/onosproject/net/behaviour/BngProgrammable.java
@@ -54,13 +54,15 @@
      *              BngProgrammable.
      * @throws BngProgrammableException while writing on BNG device.
      */
-    void cleanUp(ApplicationId appId) throws BngProgrammableException;
+    void cleanUp(ApplicationId appId)
+            throws BngProgrammableException;
 
     /**
      * Set up the necessary state to enable termination of the attachment
-     * traffic. Make also sure that the state of the given attachment is cleaned
-     * up. If the attachment is active, packets will be forwarded/terminated
-     * after calling this method, if not they will be dropped.
+     * traffic. If the attachment is active, packets will be
+     * forwarded/terminated after calling this method, if not they will be
+     * dropped. State, if already present in the data plane, will not be cleaned
+     * (e.g., counters).
      *
      * @param attachmentInfo Attachment information to configure the line
      *                       termination.
@@ -77,8 +79,10 @@
      *
      * @param attachmentInfo Attachment information to remove the line
      *                       termination.
+     * @throws BngProgrammableException while writing on BNG device.
      */
-    void removeAttachment(Attachment attachmentInfo);
+    void removeAttachment(Attachment attachmentInfo)
+            throws BngProgrammableException;
 
     /**
      * Read all counters for a given attachment and returns a map with keys