commit 86fdd28255e500a02e341e3dffb91bf2f296f783
author Jordan Halterman <jordan@opennetworking.org> Mon Jan 07 10:25:32 2019 -0800
committer Thomas Vachuska <tom@opennetworking.org> Mon Jan 07 23:42:21 2019 +0000
tree 837971dea2b9820d54810746472a51217afc0c3f
parent af3461c289098a52c907ddf229f8e8708bab2791

Backoff costly component state checks to once per minute once node is fully started

Change-Id: I203130d9f610e15b1298f0ce4b794bbe98a5d5ac

core/net/src/main/java/org/onosproject/cluster/impl/ComponentsMonitor.java

diff --git a/core/net/src/main/java/org/onosproject/cluster/impl/ComponentsMonitor.java b/core/net/src/main/java/org/onosproject/cluster/impl/ComponentsMonitor.java
index 5fed79e..2a30d52 100644
--- a/core/net/src/main/java/org/onosproject/cluster/impl/ComponentsMonitor.java
+++ b/core/net/src/main/java/org/onosproject/cluster/impl/ComponentsMonitor.java
@@ -50,7 +50,8 @@
 
     private Logger log = LoggerFactory.getLogger(getClass());
 
-    private static final long PERIOD = 2500;
+    private static final long STARTUP_PERIOD = 2500;
+    private static final long ACTIVE_PERIOD = 60000;
 
     @Reference(cardinality = ReferenceCardinality.MANDATORY)
     protected FeaturesService featuresService;
@@ -66,11 +67,13 @@
     private ScheduledExecutorService executor = Executors.newSingleThreadScheduledExecutor(
             groupedThreads("components-monitor", "%d", log));
     private ScheduledFuture<?> poller;
+    private boolean pollerBackedOff;
 
     @Activate
     protected void activate(ComponentContext context) {
         bundleContext = context.getBundleContext();
-        poller = executor.scheduleAtFixedRate(this::checkStartedState, PERIOD, PERIOD, TimeUnit.MILLISECONDS);
+        poller = executor.scheduleAtFixedRate(
+                this::checkStartedState, STARTUP_PERIOD, STARTUP_PERIOD, TimeUnit.MILLISECONDS);
         log.info("Started");
     }
 
@@ -81,8 +84,44 @@
         log.info("Stopped");
     }
 
+    /**
+     * Increases the rate at which {@link #checkStartedState()} is called once the node has been fully started.
+     */
+    private void backoffPoller() {
+        if (!pollerBackedOff) {
+            poller.cancel(false);
+            poller = executor.scheduleAtFixedRate(
+                    this::checkStartedState, ACTIVE_PERIOD, ACTIVE_PERIOD, TimeUnit.MILLISECONDS);
+            pollerBackedOff = true;
+        }
+    }
+
+    /**
+     * Decreases the rate at which {@link #checkStartedState()} is called when the node becomes unready.
+     */
+    private void revertPoller() {
+        if (pollerBackedOff) {
+            poller.cancel(false);
+            poller = executor.scheduleAtFixedRate(
+                    this::checkStartedState, STARTUP_PERIOD, STARTUP_PERIOD, TimeUnit.MILLISECONDS);
+            pollerBackedOff = false;
+        }
+    }
+
+    /**
+     * Checks whether all components are active and marks the node READY if so.
+     */
     private void checkStartedState() {
-        clusterAdminService.markFullyStarted(isFullyStarted());
+        boolean isFullyStarted = isFullyStarted();
+        clusterAdminService.markFullyStarted(isFullyStarted);
+
+        // If the node is fully started, decrease the rate at which we poll component states.
+        // Otherwise, increase the rate at which we poll component states until the node becomes ready.
+        if (isFullyStarted) {
+            backoffPoller();
+        } else {
+            revertPoller();
+        }
     }
 
     /**