commit 85c4197a839d97b3d79152564d00cd751ba8d487
author alshabib <alshabibi.ali@gmail.com> Fri Oct 03 13:48:39 2014 -0700
committer alshabib <alshabibi.ali@gmail.com> Fri Oct 03 13:48:39 2014 -0700
tree 27169484c2d0840190373e463a3f515ab5957ba6
parent a0e0498e2637981c5a9afedb148bd815fc2f0c40

flow service idle timeout based on wall clock

Change-Id: Ifb2c15ab9e5c5b07c58f3194ff2152cef650a6ae

core/net/src/main/java/org/onlab/onos/net/flow/impl/FlowRuleManager.java

diff --git a/core/net/src/main/java/org/onlab/onos/net/flow/impl/FlowRuleManager.java b/core/net/src/main/java/org/onlab/onos/net/flow/impl/FlowRuleManager.java
index db82eed..ae6a81d 100644
--- a/core/net/src/main/java/org/onlab/onos/net/flow/impl/FlowRuleManager.java
+++ b/core/net/src/main/java/org/onlab/onos/net/flow/impl/FlowRuleManager.java
@@ -7,7 +7,6 @@
 import java.util.List;
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.atomic.AtomicInteger;
 
 import org.apache.felix.scr.annotations.Activate;
 import org.apache.felix.scr.annotations.Component;
@@ -62,7 +61,7 @@
     @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY)
     protected DeviceService deviceService;
 
-    private final Map<FlowRule, AtomicInteger> deadRounds = new ConcurrentHashMap<>();
+    private final Map<FlowRule, Long> idleTime = new ConcurrentHashMap<>();
 
     @Activate
     public void activate() {
@@ -89,7 +88,7 @@
             FlowRule f = flowRules[i];
             final Device device = deviceService.getDevice(f.deviceId());
             final FlowRuleProvider frp = getProvider(device.providerId());
-            deadRounds.put(f, new AtomicInteger(0));
+            idleTime.put(f, System.currentTimeMillis());
             store.storeFlowRule(f);
             frp.applyFlowRule(f);
         }
@@ -104,7 +103,7 @@
             f = flowRules[i];
             device = deviceService.getDevice(f.deviceId());
             frp = getProvider(device.providerId());
-            deadRounds.remove(f);
+            idleTime.remove(f);
             store.deleteFlowRule(f);
             frp.removeFlowRule(f);
         }
@@ -225,7 +224,7 @@
             checkNotNull(flowRule, FLOW_RULE_NULL);
             checkValidity();
 
-            if (deadRounds.containsKey(flowRule) &&
+            if (idleTime.containsKey(flowRule) &&
                     checkRuleLiveness(flowRule, store.getFlowRule(flowRule))) {
 
                 FlowRuleEvent event = store.addOrUpdateFlowRule(flowRule);
@@ -242,16 +241,14 @@
         }
 
         private boolean checkRuleLiveness(FlowRule swRule, FlowRule storedRule) {
-            return true;
-//            int timeout = storedRule.timeout();
-//            if (storedRule.packets() != swRule.packets()) {
-//                deadRounds.get(swRule).set(0);
-//                return true;
-//            }
-//
-//            return (deadRounds.get(swRule).getAndIncrement() *
-//                    FlowRuleProvider.POLL_INTERVAL) <= timeout;
-//
+            long timeout = storedRule.timeout() * 1000;
+            Long currentTime = System.currentTimeMillis();
+            if (storedRule.packets() != swRule.packets()) {
+                idleTime.put(swRule, currentTime);
+                return true;
+            }
+            return (currentTime - idleTime.get(swRule)) <= timeout;
+
         }
 
         // Posts the specified event to the local event dispatcher.