tree cf430e82cd2769d781121182b5bfb4cacacc7d31
parent 178046ba11ab21d94a1e818fb893931bb015734b
author Miguel Borges de Freitas <miguel-r-freitas@alticelabs.com> 1634746322 +0100
committer Pier Luigi Ventre <pier@opennetworking.org> 1635277678 +0000

[P4Runtime] Make sure write requests contain the codec failure reason

The submit() method of p4 WriteRequestImpl is returning an empty
response if there are no update messages. However, one of the reasons
for updates to be empty is the fact the catch block in
appendToRequestMsg is reached due to some invalid usage of the p4runtime
contract. In such situations, not only the user doesn't know why the
request is failing (absence of logging in ONOS) but the responseBuilder
which contains the failure is also not propagated. As a result, a future
call to P4RuntimeWriteClient.WriteResponse.isSuccess() will return
true (as if the request actually succeeded) and .all() will also not
contain the failedResponse appended during the CodecException. Added a
test to illustrate the issue.

Change-Id: I0acfd3b34b3ed1db2d91f91fed08f9d00800dda4
(cherry picked from commit 89e3d23d2b865d1f94c3f5d31c792ffe33d01311)