commit | 74e5913ec3a7ee58b207ba2501cc5a53e15bf644 | [log] [tgz] |
---|---|---|
author | Ray Milkey <ray@opennetworking.org> | Wed Jan 17 15:24:52 2018 -0800 |
committer | Thomas Vachuska <tom@opennetworking.org> | Thu Jan 18 19:01:54 2018 +0000 |
tree | 3b5cb1fa86d9180ef7e08d4fc2caf27cec45ad39 | |
parent | 325c7575fa161fb83a2c8e1e512bdf6795063fc4 [diff] |
Sonar suggestions - fixes to potential null pointer dereferences Change-Id: I4e350a9d72a9322971d5d4f831f1bdf167986b87
diff --git a/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/MpReachNlri.java b/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/MpReachNlri.java index 106c4bb..578f4fe 100644 --- a/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/MpReachNlri.java +++ b/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/MpReachNlri.java
@@ -447,7 +447,7 @@ if (listIterator.hasNext()) { tlv1 = listIterator.next(); } - while (listIterator.hasNext()) { + while (tlv1 != null && listIterator.hasNext()) { BgpValueType tlv = listIterator.next(); if (tlv.getType() != tlv1.getType()) { isAllFlowTypesIdentical = false;
diff --git a/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/MpUnReachNlri.java b/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/MpUnReachNlri.java index e06fb0a..ac63ba7 100644 --- a/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/MpUnReachNlri.java +++ b/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/MpUnReachNlri.java
@@ -402,7 +402,7 @@ if (listIterator.hasNext()) { tlv1 = listIterator.next(); } - while (listIterator.hasNext()) { + while (tlv1 != null && listIterator.hasNext()) { BgpValueType tlv = listIterator.next(); if (tlv.getType() != tlv1.getType()) { isAllFlowTypesIdentical = false;