commit 7138d940538966376a78ed069ec420e673f1266e
author Jordan Halterman <jordan@opennetworking.org> Fri Mar 09 11:31:09 2018 -0500
committer Charles Chan <charles@opennetworking.org> Fri Mar 09 18:29:03 2018 +0000
tree ac3f3aaec021056afffee9c5e35ee9b4b0779554
parent 22433236a4c3652c5ca2716f42833227e2882889

Use single counter for host probe index to avoid unnecessary Raft session creation

Change-Id: I59829879e291caf33fc3abd4b5bbb69f0be92261
(cherry picked from commit 14c832b664c407015798f49a787cae184639a9f1)

core/store/dist/src/main/java/org/onosproject/store/host/impl/DistributedHostStore.java

diff --git a/core/store/dist/src/main/java/org/onosproject/store/host/impl/DistributedHostStore.java b/core/store/dist/src/main/java/org/onosproject/store/host/impl/DistributedHostStore.java
index 9cf9856..bc7f197 100644
--- a/core/store/dist/src/main/java/org/onosproject/store/host/impl/DistributedHostStore.java
+++ b/core/store/dist/src/main/java/org/onosproject/store/host/impl/DistributedHostStore.java
@@ -47,6 +47,7 @@
 import org.onosproject.net.provider.ProviderId;
 import org.onosproject.store.AbstractStore;
 import org.onosproject.store.serializers.KryoNamespaces;
+import org.onosproject.store.service.AtomicCounter;
 import org.onosproject.store.service.ConsistentMap;
 import org.onosproject.store.service.MapEvent;
 import org.onosproject.store.service.MapEventListener;
@@ -94,6 +95,7 @@
     @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY)
     protected StorageService storageService;
 
+    private AtomicCounter hostProbeIndex;
     private ConsistentMap<HostId, DefaultHost> hostsConsistentMap;
     private Map<HostId, DefaultHost> hosts;
     private Map<IpAddress, Set<Host>> hostsByIp;
@@ -158,6 +160,11 @@
         pendingHostsConsistentMap.addListener(pendingHostListener);
         pendingHosts = pendingHostsConsistentMap.asJavaMap();
 
+        hostProbeIndex = storageService.atomicCounterBuilder()
+            .withName("onos-hosts-probe-index")
+            .build()
+            .asAtomicCounter();
+
         cacheCleaner.scheduleAtFixedRate(pendingHostsCache::cleanUp, 0,
                 PROBE_TIMEOUT_MS, TimeUnit.MILLISECONDS);
 
@@ -412,7 +419,7 @@
     @Override
     public MacAddress addPendingHostLocation(HostId hostId, ConnectPoint connectPoint, ProbeMode probeMode) {
         // Use ONLab OUI (3 bytes) + atomic counter (3 bytes) as the source MAC of the probe
-        long nextIndex = storageService.getAtomicCounter("onos-hosts-probe-index").getAndIncrement();
+        long nextIndex = hostProbeIndex.getAndIncrement();
         MacAddress probeMac = MacAddress.valueOf(MacAddress.NONE.toLong() + nextIndex);
         PendingHostLocation phl = new PendingHostLocation(hostId, connectPoint, probeMode);