commit 6cc91abd8d1ab9d3620abdb0279e93bf1faa6541
author Palash Kala <palash.kala@samsung.com> Tue Apr 11 20:16:21 2017 +0900
committer Yuta HIGUCHI <y-higuchi@onlab.us> Sat Apr 15 01:24:57 2017 +0000
tree f470fa32a1b9373fc35b3fbd909acb9c7680c737
parent dd70dfb2aa71272b2b1ffee44abd9712d1f0de11

[ONOS-6271] Variable device dereferenced, it might be null

Change-Id: Ibc205c593668b8e9a78950624891659a80431c5a

apps/openstacknetworking/src/main/java/org/onosproject/openstacknetworking/impl/RulePopulatorUtil.java

diff --git a/apps/openstacknetworking/src/main/java/org/onosproject/openstacknetworking/impl/RulePopulatorUtil.java b/apps/openstacknetworking/src/main/java/org/onosproject/openstacknetworking/impl/RulePopulatorUtil.java
index 3a77804..3d4c385 100644
--- a/apps/openstacknetworking/src/main/java/org/onosproject/openstacknetworking/impl/RulePopulatorUtil.java
+++ b/apps/openstacknetworking/src/main/java/org/onosproject/openstacknetworking/impl/RulePopulatorUtil.java
@@ -57,11 +57,13 @@
                                                     DeviceId deviceId,
                                                     Ip4Address remoteIp) {
         Device device = deviceService.getDevice(deviceId);
-        if (device != null && !device.is(ExtensionTreatmentResolver.class)) {
+        if (device == null) {
+            return null;
+        }
+        if (!device.is(ExtensionTreatmentResolver.class)) {
             log.error("The extension treatment is not supported");
             return null;
         }
-
         ExtensionTreatmentResolver resolver = device.as(ExtensionTreatmentResolver.class);
         ExtensionTreatment treatment = resolver.getExtensionInstruction(NICIRA_SET_TUNNEL_DST.type());
         try {