commit 69524397a611d57df3736f3338379f2855869e7f
author Ryan Goulding <ryandgoulding@gmail.com> Sat Dec 03 13:21:20 2016 -0500
committer Jonathan Hart <jono@onlab.us> Wed Jan 11 17:50:37 2017 +0000
tree 2299ee892fe33a66b9fde9bf1a5632f59edf01cf
parent fb4b04a53ba04e5ce1fd428d7f60204169c7e7ab

Enhance logging in NetconfSessionImpl

There are a few places where Throwable.getMessage() is emitted directly
instead of utilizing a Throwable argument to the Logger output methods.
Using debug as an example, when dealing with exception reporting cases,
it is, generally better to rely upon:

http://www.slf4j.org/api/org/slf4j/Logger.html#debug(java.lang.String, java.lang.Throwable)

than:

http://www.slf4j.org/api/org/slf4j/Logger.html#debug(java.lang.String)

This commit also cleans up the language of another log message.

Change-Id: I53a77286069c112aafc83ad8157a439a4d50e52e
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

protocols/netconf/ctl/src/main/java/org/onosproject/netconf/ctl/NetconfSessionImpl.java

diff --git a/protocols/netconf/ctl/src/main/java/org/onosproject/netconf/ctl/NetconfSessionImpl.java b/protocols/netconf/ctl/src/main/java/org/onosproject/netconf/ctl/NetconfSessionImpl.java
index b080b4e..29a5dfc 100644
--- a/protocols/netconf/ctl/src/main/java/org/onosproject/netconf/ctl/NetconfSessionImpl.java
+++ b/protocols/netconf/ctl/src/main/java/org/onosproject/netconf/ctl/NetconfSessionImpl.java
@@ -129,8 +129,8 @@
                             deviceInfo.name(), deviceInfo.password());
                 }
             } catch (IOException e) {
-                log.error("Authentication connection to device {} failed: {} ",
-                          deviceInfo.getDeviceId(), e.getMessage());
+                log.error("Authentication connection to device {} failed",
+                          deviceInfo.getDeviceId(), e);
                 throw new NetconfException("Authentication connection to device " +
                                                    deviceInfo.getDeviceId() + " failed", e);
             }
@@ -154,7 +154,7 @@
             this.addDeviceOutputListener(new NetconfDeviceOutputEventListenerImpl(deviceInfo));
             sendHello();
         } catch (IOException e) {
-            log.error("Failed to create ch.ethz.ssh2.Session session." + e.getMessage());
+            log.error("Failed to create ch.ethz.ssh2.Session session.", e);
             throw new NetconfException("Failed to create ch.ethz.ssh2.Session session with device" +
                                                deviceInfo, e);
         }
@@ -246,7 +246,7 @@
             try {
                 startSshSession();
             } catch (IOException e) {
-                log.debug("The connection with {} had to be reopened", deviceInfo.getDeviceId());
+                log.debug("The connection with {} was reopened", deviceInfo.getDeviceId());
                 try {
                     startConnection();
                 } catch (IOException e2) {