commit 676249ca1a4724f06b4781aedee490dbbbcfc20f
author Ray Milkey <ray@onlab.us> Fri Dec 18 09:27:03 2015 -0800
committer Ray Milkey <ray@onlab.us> Wed Dec 30 19:02:11 2015 +0000
tree efbbf8a76ab0145c763c461e597ebd2000d15b3b
parent 0fce0404355ada36c0e9bbc561eec692bcaa57a4

Fix Sonar critical flagged bugs

Change-Id: I60e9f72a1a66f65366d7dbc5335922e75097c9f3

drivers/src/main/java/org/onosproject/driver/handshaker/OFOpticalSwitch13.java

diff --git a/drivers/src/main/java/org/onosproject/driver/handshaker/OFOpticalSwitch13.java b/drivers/src/main/java/org/onosproject/driver/handshaker/OFOpticalSwitch13.java
index 5c6ce36..c7409e9 100644
--- a/drivers/src/main/java/org/onosproject/driver/handshaker/OFOpticalSwitch13.java
+++ b/drivers/src/main/java/org/onosproject/driver/handshaker/OFOpticalSwitch13.java
@@ -70,9 +70,7 @@
         try {
             sendHandshakeOFExperimenterPortDescRequest();
         } catch (IOException e) {
-            log.error("Failed to send handshaker message OFExperimenterPortDescRequestfor sw {}, {}",
-                     getStringId(), e.getMessage());
-            e.printStackTrace();
+            log.error("Failed to send handshaker message OFExperimenterPortDescRequestfor sw {}", e);
         }
     }
 

drivers/src/main/java/org/onosproject/driver/handshaker/OfOpticalSwitchImplLinc13.java

diff --git a/drivers/src/main/java/org/onosproject/driver/handshaker/OfOpticalSwitchImplLinc13.java b/drivers/src/main/java/org/onosproject/driver/handshaker/OfOpticalSwitchImplLinc13.java
index adcbb50..5f8c82f 100644
--- a/drivers/src/main/java/org/onosproject/driver/handshaker/OfOpticalSwitchImplLinc13.java
+++ b/drivers/src/main/java/org/onosproject/driver/handshaker/OfOpticalSwitchImplLinc13.java
@@ -96,8 +96,7 @@
             sendHandshakeOFExperimenterPortDescRequest();
         } catch (IOException e) {
             log.error("LINC-OE exception while sending experimenter port desc:",
-                     e.getMessage());
-            e.printStackTrace();
+                     e);
         }
     }
 

drivers/src/main/java/org/onosproject/driver/netconf/XmlConfigParser.java

diff --git a/drivers/src/main/java/org/onosproject/driver/netconf/XmlConfigParser.java b/drivers/src/main/java/org/onosproject/driver/netconf/XmlConfigParser.java
index 55826a2..5443097 100644
--- a/drivers/src/main/java/org/onosproject/driver/netconf/XmlConfigParser.java
+++ b/drivers/src/main/java/org/onosproject/driver/netconf/XmlConfigParser.java
@@ -111,7 +111,7 @@
         try {
             editcfg.save(stringWriter);
         } catch (ConfigurationException e) {
-            e.printStackTrace();
+            log.error("createControllersConfig()", e);
         }
         String s = stringWriter.toString()
                 .replaceAll("<controller>",