commit 65f27f1aaec5c7c21931d5c9c88865891374a686
author Gamze Abaka <gamze.abaka@argela.com.tr> Mon Jul 09 06:40:24 2018 +0000
committer Saurav Das <sauravdas@alumni.stanford.edu> Mon Apr 22 16:45:40 2019 -0700
tree 9510b97d5e9824a7b385ce933374af1d5d9d70c6
parent 722f74c3fded01e2a850a86353806fbb3c1273ef

ONOS-7733 Meter Creation Fails :

When we want to create a meter, MeterManager & DefaultMeter.Builder gives the following error:
java.lang.IllegalArgumentException: Must specify a cell id.
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:134)
at org.onosproject.net.meter.DefaultMeter$Builder.build(DefaultMeter.java:241)
at org.onosproject.net.meter.DefaultMeter$Builder.build(DefaultMeter.java:184)
at org.onosproject.net.meter.impl.MeterManager.submit(MeterManager.java:204)

It seems that MeterManager still uses meter id instead of meter cell id. It must be changed with the proper value.

Change-Id: I623746b38af1148ca7f33efe5e48d6590a11051a
Note: Cord OLT application must create meters for the technology profile implementation and it uses 1.13.1 version.

core/net/src/main/java/org/onosproject/net/meter/impl/MeterManager.java

diff --git a/core/net/src/main/java/org/onosproject/net/meter/impl/MeterManager.java b/core/net/src/main/java/org/onosproject/net/meter/impl/MeterManager.java
index a1ff4e5..11420a9 100644
--- a/core/net/src/main/java/org/onosproject/net/meter/impl/MeterManager.java
+++ b/core/net/src/main/java/org/onosproject/net/meter/impl/MeterManager.java
@@ -208,7 +208,7 @@
                 .forDevice(request.deviceId())
                 .fromApp(request.appId())
                 .withBands(request.bands())
-                .withId(id)
+                .withCellId(id)
                 .withUnit(request.unit());
 
         if (request.isBurst()) {
@@ -228,7 +228,7 @@
                 .forDevice(request.deviceId())
                 .fromApp(request.appId())
                 .withBands(request.bands())
-                .withId(meterId)
+                .withCellId(meterId)
                 .withUnit(request.unit());
 
         if (request.isBurst()) {