Scrubbing store related TODO/FIXMEs
Change-Id: I4e6bf026845bbd5be127ecacd9956d12f3386c9e
diff --git a/core/store/dist/src/main/java/org/onosproject/store/resource/impl/DistributedLinkResourceStore.java b/core/store/dist/src/main/java/org/onosproject/store/resource/impl/DistributedLinkResourceStore.java
index 0d7f4f9..2e7dfa1 100644
--- a/core/store/dist/src/main/java/org/onosproject/store/resource/impl/DistributedLinkResourceStore.java
+++ b/core/store/dist/src/main/java/org/onosproject/store/resource/impl/DistributedLinkResourceStore.java
@@ -78,7 +78,6 @@
private final Logger log = getLogger(getClass());
- // FIXME: what is the Bandwidth unit?
private static final Bandwidth DEFAULT_BANDWIDTH = Bandwidth.valueOf(1_000);
// table to store current allocations
@@ -143,7 +142,6 @@
}
private Set<? extends ResourceAllocation> getResourceCapacity(ResourceType type, Link link) {
- // TODO: plugin/provider mechanism to add resource type in the future?
if (type == ResourceType.BANDWIDTH) {
return ImmutableSet.of(getBandwidthResourceCapacity(link));
}
@@ -154,7 +152,6 @@
}
private Set<LambdaResourceAllocation> getLambdaResourceCapacity(Link link) {
- // FIXME enumerate all the possible link/port lambdas
Set<LambdaResourceAllocation> allocations = new HashSet<>();
try {
final int waves = Integer.parseInt(link.annotations().value(wavesAnnotation));
@@ -323,7 +320,6 @@
if (log.isDebugEnabled()) {
logFailureDetail(batch, result);
}
- // FIXME throw appropriate exception, with what failed.
checkState(result.isSuccessful(), "Allocation failed");
}
}
@@ -389,7 +385,6 @@
double bwLeft = bw.bandwidth().toDouble();
bwLeft -= ((BandwidthResourceAllocation) req).bandwidth().toDouble();
if (bwLeft < 0) {
- // FIXME throw appropriate Exception
checkState(bwLeft >= 0,
"There's no Bandwidth left on %s. %s",
link, bwLeft);
@@ -399,7 +394,6 @@
// check if allocation should be accepted
if (!avail.contains(req)) {
// requested lambda was not available
- // FIXME throw appropriate exception
checkState(avail.contains(req),
"Allocating %s on %s failed",
req, link);
@@ -433,7 +427,6 @@
final String dbIntentId = toIntentDbKey(intendId);
final Collection<Link> links = allocations.links();
- // TODO: does release must happen in a batch?
boolean success;
do {
Builder tx = BatchWriteRequest.newBuilder();
@@ -476,7 +469,6 @@
checkNotNull(intentId);
VersionedValue vv = databaseService.get(INTENT_ALLOCATIONS, toIntentDbKey(intentId));
if (vv == null) {
- // FIXME: should we return null or LinkResourceAllocations with nothing allocated?
return null;
}
LinkResourceAllocations allocations = decodeIntentAllocations(vv.value());
@@ -486,7 +478,7 @@
private String toLinkDbKey(LinkKey linkid) {
// introduce cache if necessary
return linkid.toString();
- // TODO: Above is irreversible, if we need reverse conversion
+ // Note: Above is irreversible, if we need reverse conversion
// we may need something like below, due to String only limitation
// byte[] bytes = serializer.encode(linkid);
// StringBuilder builder = new StringBuilder(bytes.length * 4);