Fixed javadoc warnings in slew of legacy code. We need to keep up on this; the old stuff is pretty sloppy.
diff --git a/of/ctl/src/main/java/org/onlab/onos/of/controller/impl/OFChannelHandler.java b/of/ctl/src/main/java/org/onlab/onos/of/controller/impl/OFChannelHandler.java
index c85eb21..bcbbd26 100644
--- a/of/ctl/src/main/java/org/onlab/onos/of/controller/impl/OFChannelHandler.java
+++ b/of/ctl/src/main/java/org/onlab/onos/of/controller/impl/OFChannelHandler.java
@@ -632,7 +632,7 @@
* @param m The OFMessage that has just been received
* @param details A string giving more details about the exact nature
* of the problem.
- * @return
+ * @return display string
*/
// needs to be protected because enum members are actually subclasses
protected String getSwitchStateMessage(OFChannelHandler h,
@@ -682,7 +682,7 @@
/**
* Log an OpenFlow error message from a switch.
- * @param sw The switch that sent the error
+ * @param h The switch that sent the error
* @param error The error message
*/
@LogMessageDoc(level = "ERROR",
@@ -1185,7 +1185,7 @@
/**
* Return a string describing this switch based on the already available
* information (DPID and/or remote socket).
- * @return
+ * @return display string
*/
private String getSwitchInfoString() {
if (sw != null) {
diff --git a/of/ctl/src/main/java/org/onlab/onos/of/controller/impl/RoleManager.java b/of/ctl/src/main/java/org/onlab/onos/of/controller/impl/RoleManager.java
index f2e9581..ee3a37f 100644
--- a/of/ctl/src/main/java/org/onlab/onos/of/controller/impl/RoleManager.java
+++ b/of/ctl/src/main/java/org/onlab/onos/of/controller/impl/RoleManager.java
@@ -69,7 +69,6 @@
* Send NX role request message to the switch requesting the specified
* role.
*
- * @param sw switch to send the role request message to
* @param role role to request
*/
private int sendNxRoleRequest(RoleState role) throws IOException {
@@ -318,8 +317,7 @@
* Extract the role from an OFVendor message if the message is a
* Nicira role reply. Otherwise return null.
*
- * @param h The channel handler receiving the message
- * @param vendorMessage The vendor message to parse.
+ * @param experimenterMsg message
* @return The role in the message if the message is a Nicira role
* reply, null otherwise.
* @throws SwitchStateException If the message is a Nicira role reply
@@ -363,7 +361,7 @@
/**
* Extract the role information from an OF1.3 Role Reply Message.
- * @param h
+ *
* @param rrmsg the role message
* @return RoleReplyInfo object
* @throws SwitchStateException if the role information could not be extracted.