Revert "GUI: Added ESLint to gulp tasks GUI: Linted files Fixed an error in the build script"
This reverts commit 46c5f1087d76d93497a1e8e5593564991ccb6682.
Change-Id: I1464fdd1df075e93f885e3c1fbd02f0cc563fd4f
diff --git a/web/gui/src/main/webapp/app/fw/widget/button.js b/web/gui/src/main/webapp/app/fw/widget/button.js
index c0cf8ae..589b370 100644
--- a/web/gui/src/main/webapp/app/fw/widget/button.js
+++ b/web/gui/src/main/webapp/app/fw/widget/button.js
@@ -69,8 +69,8 @@
return {
id: id,
- width: buttonWidth,
- };
+ width: buttonWidth
+ }
}
@@ -111,8 +111,8 @@
width: buttonWidth,
selected: function () { return sel; },
toggle: _toggle,
- toggleNoCb: toggleNoCb,
- };
+ toggleNoCb: toggleNoCb
+ }
}
@@ -186,7 +186,7 @@
el: rbdiv,
id: rid,
cb: fs.isF(btn.cb) || noop,
- index: index,
+ index: index
});
if (btn.key) {
@@ -241,8 +241,8 @@
width: rsetWidth,
selected: selected,
selectedIndex: selectedIndex,
- size: function () { return rads.length; },
- };
+ size: function () { return rads.length; }
+ }
}
@@ -259,7 +259,7 @@
return {
button: button,
toggle: toggle,
- radioSet: radioSet,
+ radioSet: radioSet
};
}]);
diff --git a/web/gui/src/main/webapp/app/fw/widget/chartBuilder.js b/web/gui/src/main/webapp/app/fw/widget/chartBuilder.js
index 7a48563..e2f2959 100644
--- a/web/gui/src/main/webapp/app/fw/widget/chartBuilder.js
+++ b/web/gui/src/main/webapp/app/fw/widget/chartBuilder.js
@@ -24,7 +24,7 @@
// fs -> FnService
// wss -> WebSocketService
// ls -> LoadingService
- var $log, $interval, fs, wss, ls;
+ var $log, $interval, $timeout, fs, wss, ls;
// constants
var refreshInterval = 2000;
@@ -129,18 +129,19 @@
angular.module('onosWidget')
.factory('ChartBuilderService',
- ['$log', '$interval', 'FnService', 'WebSocketService',
+ ['$log', '$interval', '$timeout', 'FnService', 'WebSocketService',
'LoadingService',
- function (_$log_, _$interval_, _fs_, _wss_, _ls_) {
+ function (_$log_, _$interval_, _$timeout_, _fs_, _wss_, _ls_) {
$log = _$log_;
$interval = _$interval_;
+ $timeout = _$timeout_;
fs = _fs_;
wss = _wss_;
ls = _ls_;
return {
- buildChart: buildChart,
+ buildChart: buildChart
};
}]);
}());
diff --git a/web/gui/src/main/webapp/app/fw/widget/listBuilder.js b/web/gui/src/main/webapp/app/fw/widget/listBuilder.js
index 0daa8f1..edc92e9 100644
--- a/web/gui/src/main/webapp/app/fw/widget/listBuilder.js
+++ b/web/gui/src/main/webapp/app/fw/widget/listBuilder.js
@@ -56,7 +56,7 @@
.factory('ListService', [
function () {
return {
- listProps: listProps,
+ listProps: listProps
};
}]);
}());
diff --git a/web/gui/src/main/webapp/app/fw/widget/table.js b/web/gui/src/main/webapp/app/fw/widget/table.js
index 745585f..343f9ba 100644
--- a/web/gui/src/main/webapp/app/fw/widget/table.js
+++ b/web/gui/src/main/webapp/app/fw/widget/table.js
@@ -94,7 +94,7 @@
s: {
first: null,
second: null,
- touched: null,
+ touched: null
},
reset: function () {
@@ -132,7 +132,7 @@
s2 = s.second;
api[s1.dir](s1.adiv);
s2 && api.none(s2.adiv);
- },
+ }
};
// Functions for sorting table rows by header
@@ -157,12 +157,12 @@
firstCol: s1.id,
firstDir: s1.dir,
secondCol: id2,
- secondDir: dir2,
+ secondDir: dir2
};
}
angular.module('onosWidget')
- .directive('onosTableResize', ['$log', '$window', 'FnService', 'MastService',
+ .directive('onosTableResize', ['$log','$window', 'FnService', 'MastService',
function (_$log_, _$window_, _fs_, _mast_) {
return function (scope, element) {
@@ -175,7 +175,7 @@
tableElems = {
table: table,
thead: table.select('.table-header').select('table'),
- tbody: table.select('.table-body').select('table'),
+ tbody: table.select('.table-body').select('table')
},
wsz;
@@ -185,7 +185,7 @@
scope.$watchCollection(function () {
return {
h: $window.innerHeight,
- w: $window.innerWidth,
+ w: $window.innerWidth
};
}, function () {
wsz = fs.windowSize(0, 30);
diff --git a/web/gui/src/main/webapp/app/fw/widget/tableBuilder.js b/web/gui/src/main/webapp/app/fw/widget/tableBuilder.js
index 9f1b0ab..b23bfd0 100644
--- a/web/gui/src/main/webapp/app/fw/widget/tableBuilder.js
+++ b/web/gui/src/main/webapp/app/fw/widget/tableBuilder.js
@@ -21,7 +21,7 @@
'use strict';
// injected refs
- var $log, $interval, fs, wss, ls;
+ var $log, $interval, $timeout, fs, wss, ls;
// constants
var refreshInterval = 2000;
@@ -141,18 +141,19 @@
angular.module('onosWidget')
.factory('TableBuilderService',
- ['$log', '$interval', 'FnService', 'WebSocketService',
+ ['$log', '$interval', '$timeout', 'FnService', 'WebSocketService',
'LoadingService',
- function (_$log_, _$interval_, _fs_, _wss_, _ls_) {
+ function (_$log_, _$interval_, _$timeout_, _fs_, _wss_, _ls_) {
$log = _$log_;
$interval = _$interval_;
+ $timeout = _$timeout_;
fs = _fs_;
wss = _wss_;
ls = _ls_;
return {
- buildTable: buildTable,
+ buildTable: buildTable
};
}]);
diff --git a/web/gui/src/main/webapp/app/fw/widget/tableDetail.js b/web/gui/src/main/webapp/app/fw/widget/tableDetail.js
index 31aac08..57f65a7 100644
--- a/web/gui/src/main/webapp/app/fw/widget/tableDetail.js
+++ b/web/gui/src/main/webapp/app/fw/widget/tableDetail.js
@@ -21,7 +21,7 @@
'use strict';
// injected refs
- var $log, fs;
+ var $log, $interval, $timeout, fs, wss;
// constants
// var refreshInterval = 2000;
@@ -50,14 +50,17 @@
// TODO: add ref to PanelService
angular.module('onosWidget')
.factory('TableDetailService',
- ['$log', 'FnService',
+ ['$log', '$interval', '$timeout', 'FnService', 'WebSocketService',
- function (_$log_, _fs_) {
+ function (_$log_, _$interval_, _$timeout_, _fs_, _wss_) {
$log = _$log_;
+ $interval = _$interval_;
+ $timeout = _$timeout_;
fs = _fs_;
+ wss = _wss_;
return {
- buildBasePanel: buildBasePanel,
+ buildBasePanel: buildBasePanel
};
}]);
}());
diff --git a/web/gui/src/main/webapp/app/fw/widget/toolbar.js b/web/gui/src/main/webapp/app/fw/widget/toolbar.js
index 6ac1847..b765208 100644
--- a/web/gui/src/main/webapp/app/fw/widget/toolbar.js
+++ b/web/gui/src/main/webapp/app/fw/widget/toolbar.js
@@ -38,7 +38,7 @@
top: 'auto',
bottom: '10px',
fade: false,
- shown: false,
+ shown: false
};
// internal state
@@ -81,8 +81,8 @@
panel = ps.createPanel(tbid, settings),
arrowDiv = createArrow(panel),
currentRow = panel.append('div').classed('tbar-row', true),
- rowButtonIds = [], // for removable buttons
- tbWidth = arrowSize + 2, // empty toolbar width
+ rowButtonIds = [], // for removable buttons
+ tbWidth = arrowSize + 2, // empty toolbar width
maxWidth = panel.width();
arrowDiv.on('click', toggle);
@@ -92,7 +92,7 @@
settings: settings,
items: items,
panel: panel,
- panelId: tbid,
+ panelId: tbid
};
panel.classed('toolbar', true)
@@ -171,7 +171,7 @@
clear: rowClear,
setText: rowSetText,
addButton: rowAddButton,
- classed: rowClassed,
+ classed: rowClassed
};
}
}
@@ -234,7 +234,7 @@
show: show,
hide: hide,
toggle: toggle,
- isVisible: isVisible,
+ isVisible: isVisible
};
}
@@ -268,7 +268,7 @@
return {
init: init,
createToolbar: createToolbar,
- destroyToolbar: destroyToolbar,
+ destroyToolbar: destroyToolbar
};
}]);
}());
diff --git a/web/gui/src/main/webapp/app/fw/widget/tooltip.js b/web/gui/src/main/webapp/app/fw/widget/tooltip.js
index 4d8169c..beca6f8 100644
--- a/web/gui/src/main/webapp/app/fw/widget/tooltip.js
+++ b/web/gui/src/main/webapp/app/fw/widget/tooltip.js
@@ -17,11 +17,12 @@
/*
ONOS GUI -- Widget -- Tooltip Service
*/
+
(function () {
'use strict';
// injected references
- var $rootScope, fs;
+ var $log, $rootScope, fs;
// constants
var hoverHeight = 35,
@@ -44,7 +45,7 @@
style = {
display: 'inline-block',
left: 'auto',
- right: 'auto',
+ right: 'auto'
};
if (mouseX <= (winWidth / 2)) {
@@ -105,7 +106,7 @@
tooltip.transition()
.delay(exitDelay)
.style({
- display: 'none',
+ display: 'none'
})
.text('');
}
@@ -124,12 +125,13 @@
restrict: 'A',
link: function (scope, elem, attrs) {
addTooltip(d3.select(elem[0]), scope[attrs.ttMsg]);
- },
+ }
};
}])
- .factory('TooltipService', ['$rootScope', 'FnService',
- function (_$rootScope_, _fs_) {
+ .factory('TooltipService', ['$log', '$rootScope', 'FnService',
+ function (_$log_, _$rootScope_, _fs_) {
+ $log = _$log_;
$rootScope = _$rootScope_;
fs = _fs_;
@@ -138,7 +140,7 @@
return {
addTooltip: addTooltip,
showTooltip: showTooltip,
- cancelTooltip: cancelTooltip,
+ cancelTooltip: cancelTooltip
};
}]);
}());