Relax meters translation checks
Change-Id: I1dd3d2c9642ebff28d68425a7bcbc01c4d6a15f5
diff --git a/core/net/src/main/java/org/onosproject/net/pi/impl/PiMeterTranslatorImpl.java b/core/net/src/main/java/org/onosproject/net/pi/impl/PiMeterTranslatorImpl.java
index 48cd4ba..3a24395 100644
--- a/core/net/src/main/java/org/onosproject/net/pi/impl/PiMeterTranslatorImpl.java
+++ b/core/net/src/main/java/org/onosproject/net/pi/impl/PiMeterTranslatorImpl.java
@@ -68,12 +68,13 @@
throw new PiTranslationException("PI TCM meter must have a MARK_YELLOW band and a MARK_RED band!");
}
- // Validate proper config of the trTCM settings
- if (bands[0].burst() <= 0 || bands[1].burst() <= 0) {
- throw new PiTranslationException("PI trTCM meter can not have band with burst <= 0!");
+ // Validate proper config. NOTE that we have relaxed some checks
+ // and the ONOS meters are not spec compliants with trTCM RFC
+ if (bands[0].burst() < 0 || bands[1].burst() < 0) {
+ throw new PiTranslationException("PI trTCM meter can not have band with burst < 0!");
}
- if (bands[0].rate() <= 0 || bands[1].rate() <= 0) {
- throw new PiTranslationException("PI trTCM meter can not have band with rate <= 0!");
+ if (bands[0].rate() < 0 || bands[1].rate() < 0) {
+ throw new PiTranslationException("PI trTCM meter can not have band with rate < 0!");
}
long cir, cburst, pir, pburst;