Started to work on topology abstraction.
Added more unit tests.
Changed mastership application to be synchronous.
diff --git a/net/api/src/main/java/org/onlab/onos/net/DefaultEdgeLink.java b/net/api/src/main/java/org/onlab/onos/net/DefaultEdgeLink.java
index fe2d34a..41cd045 100644
--- a/net/api/src/main/java/org/onlab/onos/net/DefaultEdgeLink.java
+++ b/net/api/src/main/java/org/onlab/onos/net/DefaultEdgeLink.java
@@ -37,7 +37,7 @@
}
@Override
- public ConnectPoint connectPoint() {
+ public HostLocation hostLocation() {
return hostLocation;
}
}
diff --git a/net/api/src/main/java/org/onlab/onos/net/DeviceId.java b/net/api/src/main/java/org/onlab/onos/net/DeviceId.java
index 19577a1..ef8c5ab 100644
--- a/net/api/src/main/java/org/onlab/onos/net/DeviceId.java
+++ b/net/api/src/main/java/org/onlab/onos/net/DeviceId.java
@@ -27,7 +27,7 @@
* @param string device URI string
*/
public static DeviceId deviceId(String string) {
- return new DeviceId(URI.create(string));
+ return deviceId(URI.create(string));
}
}
diff --git a/net/api/src/main/java/org/onlab/onos/net/EdgeLink.java b/net/api/src/main/java/org/onlab/onos/net/EdgeLink.java
index 356592d3..b1d5f7f 100644
--- a/net/api/src/main/java/org/onlab/onos/net/EdgeLink.java
+++ b/net/api/src/main/java/org/onlab/onos/net/EdgeLink.java
@@ -17,8 +17,8 @@
* Returns the connection point where the host attaches to the
* network infrastructure.
*
- * @return host connection point
+ * @return host location point
*/
- ConnectPoint connectPoint();
+ HostLocation hostLocation();
}
diff --git a/net/api/src/main/java/org/onlab/onos/net/HostId.java b/net/api/src/main/java/org/onlab/onos/net/HostId.java
index a7f550b..3e274b3 100644
--- a/net/api/src/main/java/org/onlab/onos/net/HostId.java
+++ b/net/api/src/main/java/org/onlab/onos/net/HostId.java
@@ -27,7 +27,7 @@
* @param string device URI string
*/
public static HostId hostId(String string) {
- return new HostId(URI.create(string));
+ return hostId(URI.create(string));
}
}
diff --git a/net/api/src/main/java/org/onlab/onos/net/topology/LinkWeight.java b/net/api/src/main/java/org/onlab/onos/net/topology/LinkWeight.java
new file mode 100644
index 0000000..89ef577
--- /dev/null
+++ b/net/api/src/main/java/org/onlab/onos/net/topology/LinkWeight.java
@@ -0,0 +1,10 @@
+package org.onlab.onos.net.topology;
+
+import org.onlab.graph.EdgeWeight;
+
+/**
+ * Entity capable of determining cost or weight of a specified topology
+ * graph edge.
+ */
+public interface LinkWeight extends EdgeWeight<TopoVertex, TopoEdge> {
+}
diff --git a/net/api/src/main/java/org/onlab/onos/net/topology/TopoEdge.java b/net/api/src/main/java/org/onlab/onos/net/topology/TopoEdge.java
new file mode 100644
index 0000000..ef94eca
--- /dev/null
+++ b/net/api/src/main/java/org/onlab/onos/net/topology/TopoEdge.java
@@ -0,0 +1,18 @@
+package org.onlab.onos.net.topology;
+
+import org.onlab.graph.Edge;
+import org.onlab.onos.net.Link;
+
+/**
+ * Represents an edge in the topology graph.
+ */
+public interface TopoEdge extends Edge<TopoVertex> {
+
+ /**
+ * Returns the associated infrastructure link.
+ *
+ * @return backing infrastructure link
+ */
+ Link link();
+
+}
diff --git a/net/api/src/main/java/org/onlab/onos/net/topology/TopoVertex.java b/net/api/src/main/java/org/onlab/onos/net/topology/TopoVertex.java
new file mode 100644
index 0000000..d5a8b95
--- /dev/null
+++ b/net/api/src/main/java/org/onlab/onos/net/topology/TopoVertex.java
@@ -0,0 +1,18 @@
+package org.onlab.onos.net.topology;
+
+import org.onlab.graph.Vertex;
+import org.onlab.onos.net.DeviceId;
+
+/**
+ * Represents a vertex in the topology graph.
+ */
+public interface TopoVertex extends Vertex {
+
+ /**
+ * Returns the associated infrastructure device identification.
+ *
+ * @return device identifier
+ */
+ DeviceId deviceId();
+
+}
diff --git a/net/api/src/main/java/org/onlab/onos/net/topology/TopologyCluster.java b/net/api/src/main/java/org/onlab/onos/net/topology/TopologyCluster.java
new file mode 100644
index 0000000..e58c784
--- /dev/null
+++ b/net/api/src/main/java/org/onlab/onos/net/topology/TopologyCluster.java
@@ -0,0 +1,10 @@
+package org.onlab.onos.net.topology;
+
+/**
+ * Representation of an SCC (strongly-connected component) in a network topology.
+ */
+public interface TopologyCluster {
+
+ // TODO: add stuff in here: id, deviceCount, linkCount
+
+}
diff --git a/net/api/src/main/java/org/onlab/onos/net/topology/TopologyService.java b/net/api/src/main/java/org/onlab/onos/net/topology/TopologyService.java
index 4e1211a..a6962a2 100644
--- a/net/api/src/main/java/org/onlab/onos/net/topology/TopologyService.java
+++ b/net/api/src/main/java/org/onlab/onos/net/topology/TopologyService.java
@@ -1,7 +1,13 @@
package org.onlab.onos.net.topology;
+import org.onlab.graph.Graph;
+import org.onlab.onos.net.ConnectPoint;
+import org.onlab.onos.net.DeviceId;
+import org.onlab.onos.net.Path;
import org.onlab.onos.net.Topology;
+import java.util.Set;
+
/**
* Service for providing network topology information.
*/
@@ -14,13 +20,64 @@
*/
Topology currentTopology();
- // TODO: Figure out hot to best export graph traversal methods via Graph/Vertex/Edge
- // TODO: figure out how we want this to be presented, via Topology or via TopologyService
- // Set<TopologyCluster> getClusters(Topology topology);
- // Set<Path> getPaths(Topology topology, DeviceId src, DeviceId dst);
- // Set<Path> getPaths(Topology topology, DeviceId src, DeviceId dst, LinkWeight weight);
- // boolean isInfrastructure(Topology topology, ConnectPoint connectPoint);
- // boolean isInBroadcastTree(Topology topology, ConnectPoint connectPoint);
+ /**
+ * Returns the set of clusters in the specified topology.
+ *
+ * @param topology topology descriptor
+ * @return set of topology clusters
+ */
+ Set<TopologyCluster> getClusters(Topology topology);
+
+ /**
+ * Returns the graph view of the specified topology.
+ *
+ * @param topology topology descriptor
+ * @return topology graph view
+ */
+ Graph<TopoVertex, TopoEdge> getGraph(Topology topology);
+
+ /**
+ * Returns the set of all shortest paths, in terms of hop-count, between
+ * the specified source and destination devices.
+ *
+ * @param topology topology descriptor
+ * @param src source device
+ * @param dst destination device
+ * @return set of all shortest paths between the two devices
+ */
+ Set<Path> getPaths(Topology topology, DeviceId src, DeviceId dst);
+
+ /**
+ * Returns the set of all shortest paths, computed using the supplied
+ * edge-weight entity, between the specified source and destination devices.
+ *
+ * @param topology topology descriptor
+ * @param src source device
+ * @param dst destination device
+ * @return set of all shortest paths between the two devices
+ */
+ Set<Path> getPaths(Topology topology, DeviceId src, DeviceId dst,
+ LinkWeight weight);
+
+ /**
+ * Indicates whether the specified connection point is part of the network
+ * infrastructure or part of network edge.
+ *
+ * @param topology topology descriptor
+ * @param connectPoint connection point
+ * @return true of connection point is in infrastructure; false if edge
+ */
+ boolean isInfrastructure(Topology topology, ConnectPoint connectPoint);
+
+
+ /**
+ * Indicates whether the specified connection point allows broadcast.
+ *
+ * @param topology topology descriptor
+ * @param connectPoint connection point
+ * @return true if broadcast is permissible
+ */
+ boolean isInBroadcastTree(Topology topology, ConnectPoint connectPoint);
/**
* Adds the specified topology listener.