Deprecate potentially error prone constructor methods
Change-Id: I82d95c27dc7c4b1a6dcf5cc48a1c7583b5e30e2c
diff --git a/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/OpenFlowDeviceProvider.java b/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/OpenFlowDeviceProvider.java
index cfaf107..fad323e 100644
--- a/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/OpenFlowDeviceProvider.java
+++ b/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/OpenFlowDeviceProvider.java
@@ -1163,11 +1163,13 @@
if (ether.isPresent()) {
// ethernet port
// TODO parse other part of OFPortDescPropEthernet if necessary
- return new DefaultPortDescription(portNo,
- enabled,
- COPPER,
- portSpeed(port),
- annotations.build());
+ return DefaultPortDescription.builder()
+ .withPortNumber(portNo)
+ .isEnabled(enabled)
+ .type(COPPER)
+ .portSpeed(portSpeed(port))
+ .annotations(annotations.build())
+ .build();
}
Optional<OFPortDescPropOptical> optical = port.getProperties().stream()
@@ -1237,19 +1239,23 @@
// TODO How to determine appropriate port type?
- return new DefaultPortDescription(portNo,
- enabled,
- FIBER,
- portSpeed(port),
- annotations.build());
+ return DefaultPortDescription.builder()
+ .withPortNumber(portNo)
+ .isEnabled(enabled)
+ .type(FIBER)
+ .portSpeed(portSpeed(port))
+ .annotations(annotations.build())
+ .build();
}
// fall back default
- return new DefaultPortDescription(portNo,
- enabled,
- COPPER,
- portSpeed(port),
- annotations.build());
+ return DefaultPortDescription.builder()
+ .withPortNumber(portNo)
+ .isEnabled(enabled)
+ .type(COPPER)
+ .portSpeed(portSpeed(port))
+ .annotations(annotations.build())
+ .build();
}
@@ -1272,8 +1278,13 @@
SparseAnnotations annotations = makePortAnnotation(port.getName(),
port.getHwAddr().toString(),
adminDown).build();
- return new DefaultPortDescription(portNo, enabled, type,
- portSpeed(port), annotations);
+ return DefaultPortDescription.builder()
+ .withPortNumber(portNo)
+ .isEnabled(enabled)
+ .type(type)
+ .portSpeed(portSpeed(port))
+ .annotations(annotations)
+ .build();
}
/**
@@ -1349,7 +1360,13 @@
break;
}
- return new DefaultPortDescription(portNo, enabled, FIBER, 0, annotations);
+ return DefaultPortDescription.builder()
+ .withPortNumber(portNo)
+ .isEnabled(enabled)
+ .type(FIBER)
+ .portSpeed(0)
+ .annotations(annotations)
+ .build();
}
/**