Deprecate potentially error prone constructor methods
Change-Id: I82d95c27dc7c4b1a6dcf5cc48a1c7583b5e30e2c
diff --git a/providers/netconf/device/src/main/java/org/onosproject/provider/netconf/device/impl/NetconfDeviceProvider.java b/providers/netconf/device/src/main/java/org/onosproject/provider/netconf/device/impl/NetconfDeviceProvider.java
index 9cf81d0..f675dbc 100644
--- a/providers/netconf/device/src/main/java/org/onosproject/provider/netconf/device/impl/NetconfDeviceProvider.java
+++ b/providers/netconf/device/src/main/java/org/onosproject/provider/netconf/device/impl/NetconfDeviceProvider.java
@@ -356,9 +356,14 @@
Port port = deviceService.getPort(deviceId, portNumber);
//rebuilding port description with admin state changed.
providerService.portStatusChanged(deviceId,
- new DefaultPortDescription(portNumber, enable, false,
- port.type(), port.portSpeed(),
- (SparseAnnotations) port.annotations()));
+ DefaultPortDescription.builder()
+ .withPortNumber(portNumber)
+ .isEnabled(enable)
+ .isRemoved(false)
+ .type(port.type())
+ .portSpeed(port.portSpeed())
+ .annotations((SparseAnnotations) port.annotations())
+ .build());
} else {
log.warn("Your device {} port {} status can't be changed to {}",
deviceId, portNumber, enable);
diff --git a/providers/netconf/device/src/test/java/org/onosproject/provider/netconf/device/impl/NetconfDeviceProviderTest.java b/providers/netconf/device/src/test/java/org/onosproject/provider/netconf/device/impl/NetconfDeviceProviderTest.java
index c16de45..29d16ba 100644
--- a/providers/netconf/device/src/test/java/org/onosproject/provider/netconf/device/impl/NetconfDeviceProviderTest.java
+++ b/providers/netconf/device/src/test/java/org/onosproject/provider/netconf/device/impl/NetconfDeviceProviderTest.java
@@ -286,7 +286,8 @@
private void prepareMocks(int count) {
for (int i = 1; i <= count; i++) {
- deviceDescription.portDescriptions.add(new DefaultPortDescription(PortNumber.portNumber(i), true));
+ deviceDescription.portDescriptions.add(DefaultPortDescription.builder()
+ .withPortNumber(PortNumber.portNumber(i)).isEnabled(true).build());
}
}