added Host-related unit tests
Change-Id: Ia3c0610f5bdd91ddd554dd477af7ad3640a6cef3
diff --git a/utils/misc/src/main/java/org/onlab/packet/IPAddress.java b/utils/misc/src/main/java/org/onlab/packet/IPAddress.java
index 94c2d54..4e898f4 100644
--- a/utils/misc/src/main/java/org/onlab/packet/IPAddress.java
+++ b/utils/misc/src/main/java/org/onlab/packet/IPAddress.java
@@ -57,7 +57,7 @@
* @return an IP address
*/
public static IPAddress valueOf(String address) {
- final String [] parts = address.split(".");
+ final String [] parts = address.split("\\.");
if (parts.length != INET_LEN) {
throw new IllegalArgumentException("Malformed IP address string; "
+ "Addres must have four decimal values separated by dots (.)");
@@ -119,7 +119,9 @@
return true;
}
if (obj instanceof IPAddress) {
+
IPAddress other = (IPAddress) obj;
+
if (!(this.version.equals(other.version))) {
return false;
}
diff --git a/utils/misc/src/main/java/org/onlab/packet/VLANID.java b/utils/misc/src/main/java/org/onlab/packet/VLANID.java
index 31cdecb..5b26d04 100644
--- a/utils/misc/src/main/java/org/onlab/packet/VLANID.java
+++ b/utils/misc/src/main/java/org/onlab/packet/VLANID.java
@@ -37,12 +37,12 @@
}
if (obj instanceof VLANID) {
- return true;
- }
- VLANID other = (VLANID) obj;
- if (this.value == other.value) {
- return true;
+ VLANID other = (VLANID) obj;
+
+ if (this.value == other.value) {
+ return true;
+ }
}
return false;