commit 4fd3ceb3df8b2ef29bad140f020d60fe93a37345
author Ray Milkey <ray@onlab.us> Thu Dec 10 14:43:08 2015 -0800
committer Gerrit Code Review <gerrit@onlab.us> Thu Dec 17 17:39:44 2015 +0000
tree 2095d2c8a1fd2065c3a766dd7c8dfa0e72a650fa
parent baf705480d10f522eeee303bb1d3a3f83cdc0523

[Falcon] fixes for Sonar Critical bugs

Change-Id: I0a63578727693a2517f3002bd4f4c391b6f44aea

cli/src/main/java/org/onosproject/cli/net/AddTestFlowsCommand.java

diff --git a/cli/src/main/java/org/onosproject/cli/net/AddTestFlowsCommand.java b/cli/src/main/java/org/onosproject/cli/net/AddTestFlowsCommand.java
index e1e158a..4a741ed 100644
--- a/cli/src/main/java/org/onosproject/cli/net/AddTestFlowsCommand.java
+++ b/cli/src/main/java/org/onosproject/cli/net/AddTestFlowsCommand.java
@@ -63,6 +63,7 @@
     String numOfRuns = null;
 
     @Override
+    @java.lang.SuppressWarnings("squid:S1148")
     protected void execute() {
         FlowRuleService flowService = get(FlowRuleService.class);
         DeviceService deviceService = get(DeviceService.class);

cli/src/main/java/org/onosproject/cli/security/ReviewCommand.java

diff --git a/cli/src/main/java/org/onosproject/cli/security/ReviewCommand.java b/cli/src/main/java/org/onosproject/cli/security/ReviewCommand.java
index 9d17eb2..cf24e01 100644
--- a/cli/src/main/java/org/onosproject/cli/security/ReviewCommand.java
+++ b/cli/src/main/java/org/onosproject/cli/security/ReviewCommand.java
@@ -114,6 +114,7 @@
                         print("\t[Other] " + perm.getClass().getSimpleName() +
                                 " " + perm.getName() + " (" + perm.getActions() + ")");
                     }
+                    break;
                 default:
                     break;
             }