commit 485da340d69fbb6cb47b27c57914516ed84362c3
author Jordan Halterman <jordan@onlab.us> Wed May 31 14:13:53 2017 -0700
committer Ray Milkey <ray@onlab.us> Thu Jun 01 20:57:04 2017 +0000
tree 25755a2c6f9998a7248d8959ac9837c8fbc2950e
parent 4b765c3efef6c94850d76c417c1b9c2db3d9e4b6

Optimize FlowId hash computation.

Change-Id: If476d87c41658bba2b3d9fbe2f80265672a38019

core/api/src/main/java/org/onosproject/net/flow/DefaultFlowRule.java

diff --git a/core/api/src/main/java/org/onosproject/net/flow/DefaultFlowRule.java b/core/api/src/main/java/org/onosproject/net/flow/DefaultFlowRule.java
index 7c632b1..0a8ecfb 100644
--- a/core/api/src/main/java/org/onosproject/net/flow/DefaultFlowRule.java
+++ b/core/api/src/main/java/org/onosproject/net/flow/DefaultFlowRule.java
@@ -15,7 +15,6 @@
  */
 package org.onosproject.net.flow;
 
-import com.google.common.base.Charsets;
 import com.google.common.hash.Funnel;
 import com.google.common.hash.HashCode;
 import com.google.common.hash.HashFunction;
@@ -505,12 +504,14 @@
         }
 
         private int hash() {
+            // Guava documentation recommends using putUnencodedChars to hash raw character bytes within any encoding
+            // unless cross-language compatibility is needed. See the Hasher.putString documentation for more info.
             Funnel<TrafficSelector> selectorFunnel = (from, into) -> from.criteria()
-                    .forEach(c -> into.putString(c.toString(), Charsets.UTF_8));
+                    .forEach(c -> into.putUnencodedChars(c.toString()));
 
             HashFunction hashFunction = Hashing.murmur3_32();
             HashCode hashCode = hashFunction.newHasher()
-                    .putString(deviceId.toString(), Charsets.UTF_8)
+                    .putUnencodedChars(deviceId.toString())
                     .putObject(selector, selectorFunnel)
                     .putInt(priority)
                     .putInt(tableId)