commit 42b620389692cf8d86e27cf232b7771d890c6224
author Ray Milkey <ray@opennetworking.org> Thu Feb 01 11:15:31 2018 -0800
committer Thomas Vachuska <tom@opennetworking.org> Thu Feb 01 21:09:07 2018 +0000
tree c912acd655f6137d4eda5f494b03c6532d406aad
parent 5f092c47465c4f886f037a029d55fe5312ecae66

SONAR suggestion - problems with string format calls

Change-Id: Ie6b985d2e4db79d6398b17e38a680920f52366b3

cli/src/main/java/org/onosproject/cli/net/DpisListCommand.java

diff --git a/cli/src/main/java/org/onosproject/cli/net/DpisListCommand.java b/cli/src/main/java/org/onosproject/cli/net/DpisListCommand.java
index 6bdcedb..d34c9ed 100644
--- a/cli/src/main/java/org/onosproject/cli/net/DpisListCommand.java
+++ b/cli/src/main/java/org/onosproject/cli/net/DpisListCommand.java
@@ -213,7 +213,7 @@
     }
 
     private void printDpiStatisticsJson(int number, DpiStatistics ds) {
-        String index = number < 0 ? String.format("  -  ") : String.format("%5d", number);
+        String index = number < 0 ? "  -  " : String.format("%5d", number);
         if ("".equals(ds.receivedTime())) {
             print("ReceivedTime is null, No valid DPI Statistics!");
             return;
@@ -226,7 +226,7 @@
 
     private void printDpiStatisticsClass(int number, DpiStatistics ds) {
         String printLine = "";
-        String index = number < 0 ? String.format("  -  ") : String.format("%5d", number);
+        String index = number < 0 ? "  -  " : String.format("%5d", number);
 
         DpiStatInfo dsi = ds.dpiStatInfo();
         if (dsi == null) {

cli/src/main/java/org/onosproject/cli/net/IntentsListCommand.java

diff --git a/cli/src/main/java/org/onosproject/cli/net/IntentsListCommand.java b/cli/src/main/java/org/onosproject/cli/net/IntentsListCommand.java
index 8fb3714..595599d 100644
--- a/cli/src/main/java/org/onosproject/cli/net/IntentsListCommand.java
+++ b/cli/src/main/java/org/onosproject/cli/net/IntentsListCommand.java
@@ -119,7 +119,7 @@
      */
     private static final String SUMMARY_TITLES =
             BOLD + format(
-            "\n%1s%21s%14s%14s%14s%14s%14s%14s%14s%14s%14s%14s",
+            "%n%1s%21s%14s%14s%14s%14s%14s%14s%14s%14s%14s%14s",
             "Intent type",
             "Total",
             "Installed",
@@ -355,7 +355,7 @@
             StringBuilder builder = new StringBuilder();
 
             builder.append(format(
-                    "\n%1s%s%14d%14d%14d%14d%14d%14d%14d%14d%14d%14d",
+                    "%n%1s%s%14d%14d%14d%14d%14d%14d%14d%14d%14d%14d",
                     BOLD + intentType + RESET,
                     Strings.padStart(String.valueOf(total),
                                      (32 - intentType.length()),