commit 3ed7f30db31afa7ec829a2a097e4c27ba52d8228
author Jian Li <pyguni@gmail.com> Mon Aug 27 17:16:27 2018 +0900
committer Jian Li <pyguni@gmail.com> Thu Aug 30 03:55:38 2018 +0000
tree 788e7f41f2650f0fcec8a4c27dc8bf70ec8f2f6a
parent bed6151011a31ea0f93a908aab0b1b478232f076

Refactor: remove code duplication for openstacktelemetry app

Change-Id: I3a97bc22e8a49ef6184876875351ebba8111e25c

apps/openstacktelemetry/app/src/main/java/org/onosproject/openstacktelemetry/impl/KafkaTelemetryConfigManager.java

diff --git a/apps/openstacktelemetry/app/src/main/java/org/onosproject/openstacktelemetry/impl/KafkaTelemetryConfigManager.java b/apps/openstacktelemetry/app/src/main/java/org/onosproject/openstacktelemetry/impl/KafkaTelemetryConfigManager.java
index 9309c75..956e275 100644
--- a/apps/openstacktelemetry/app/src/main/java/org/onosproject/openstacktelemetry/impl/KafkaTelemetryConfigManager.java
+++ b/apps/openstacktelemetry/app/src/main/java/org/onosproject/openstacktelemetry/impl/KafkaTelemetryConfigManager.java
@@ -46,6 +46,7 @@
 import static org.onosproject.openstacktelemetry.api.Constants.DEFAULT_KAFKA_SERVER_PORT;
 import static org.onosproject.openstacktelemetry.api.Constants.DEFAULT_KAFKA_VALUE_SERIALIZER;
 import static org.onosproject.openstacktelemetry.util.OpenstackTelemetryUtil.getBooleanProperty;
+import static org.onosproject.openstacktelemetry.util.OpenstackTelemetryUtil.initTelemetryService;
 
 /**
  * Kafka server configuration manager for publishing openstack telemetry.
@@ -137,18 +138,7 @@
     @Modified
     private void modified(ComponentContext context) {
         readComponentConfiguration(context);
-
-        if (enableService) {
-            if (kafkaTelemetryAdminService.isRunning()) {
-                kafkaTelemetryAdminService.restart(getConfig());
-            } else {
-                kafkaTelemetryAdminService.start(getConfig());
-            }
-        } else {
-            if (kafkaTelemetryAdminService.isRunning()) {
-                kafkaTelemetryAdminService.stop();
-            }
-        }
+        initTelemetryService(kafkaTelemetryAdminService, getConfig(), enableService);
         log.info("Modified");
     }