Refactor channel and mastership handling in P4Runtime
This (big) change aims at solving the issue observed with mastership flapping
and device connection/disconnection with P4Runtime.
Channel handling is now based on the underlying gRPC channel state. Before,
channel events (open/close/error) were generated as a consequence of P4Runtime
StreamChannel events, making device availability dependent on mastership. Now
Stream Channel events only affect mastership (MASTER/STANDBY or NONE when the
SteamChannel RPC is not active).
Mastership handling has been refactored to generate P4Runtime election IDs that
are compatible with the mastership preference decided by the MastershipService.
GeneralDeviceProvider has been re-implemented to support in-order
device event processing and to reduce implementation complexity. Stats polling
has been moved to a separate component, and netcfg handling updated to only
depend on BasicDeviceConfig, augmented with a pipeconf field, and re-using the
managementAddress field to set the gRPC server endpoints (e.g.
grpc://myswitch.local:50051). Before it was depending on 3 different config
classes, making hard to detect changes.
Finally, this change affects some core interfaces:
- Adds a method to DeviceProvider and DeviceHandshaker to check for device
availability, making the meaning of availability device-specific. This is needed
in cases where the device manager needs to change the availability state of a
device (as in change #20842)
- Support device providers not capable of reconciling mastership role responses
with requests (like P4Runtime).
- Clarify the meaning of "connection" in the DeviceConnect behavior.
- Allows driver-based providers to check devices for reachability and
availability without probing the device via the network.
Change-Id: I7ff30d29f5d02ad938e3171536e54ae2916629a2
diff --git a/protocols/grpc/ctl/src/main/java/org/onosproject/grpc/ctl/GrpcChannelControllerImpl.java b/protocols/grpc/ctl/src/main/java/org/onosproject/grpc/ctl/GrpcChannelControllerImpl.java
index ca0c8c3..87c9426 100644
--- a/protocols/grpc/ctl/src/main/java/org/onosproject/grpc/ctl/GrpcChannelControllerImpl.java
+++ b/protocols/grpc/ctl/src/main/java/org/onosproject/grpc/ctl/GrpcChannelControllerImpl.java
@@ -41,6 +41,7 @@
import java.util.Dictionary;
import java.util.Map;
import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
@@ -152,50 +153,24 @@
}
}
- private boolean doDummyMessage(ManagedChannel channel) throws StatusRuntimeException {
+ private void doDummyMessage(ManagedChannel channel) throws StatusRuntimeException {
DummyServiceGrpc.DummyServiceBlockingStub dummyStub = DummyServiceGrpc
.newBlockingStub(channel)
.withDeadlineAfter(CONNECTION_TIMEOUT_SECONDS, TimeUnit.SECONDS);
try {
- return dummyStub.sayHello(Dummy.DummyMessageThatNoOneWouldReallyUse
- .getDefaultInstance()) != null;
+ //noinspection ResultOfMethodCallIgnored
+ dummyStub.sayHello(Dummy.DummyMessageThatNoOneWouldReallyUse
+ .getDefaultInstance());
} catch (StatusRuntimeException e) {
- if (e.getStatus().equals(Status.UNIMPLEMENTED)) {
+ if (!e.getStatus().equals(Status.UNIMPLEMENTED)) {
// UNIMPLEMENTED means that the server received our message but
// doesn't know how to handle it. Hence, channel is open.
- return true;
- } else {
throw e;
}
}
}
@Override
- public boolean isChannelOpen(GrpcChannelId channelId) {
- checkNotNull(channelId);
-
- Lock lock = channelLocks.get(channelId);
- lock.lock();
-
- try {
- if (!channels.containsKey(channelId)) {
- log.warn("Unknown channel ID '{}', can't check if channel is open",
- channelId);
- return false;
- }
- try {
- return doDummyMessage(channels.get(channelId));
- } catch (StatusRuntimeException e) {
- log.debug("Unable to send dummy message to {}: {}",
- channelId, e.toString());
- return false;
- }
- } finally {
- lock.unlock();
- }
- }
-
- @Override
public void disconnectChannel(GrpcChannelId channelId) {
checkNotNull(channelId);
@@ -240,7 +215,6 @@
Lock lock = channelLocks.get(channelId);
lock.lock();
-
try {
return Optional.ofNullable(channels.get(channelId));
} finally {
@@ -248,4 +222,23 @@
}
}
+ @Override
+ public CompletableFuture<Boolean> probeChannel(GrpcChannelId channelId) {
+ final ManagedChannel channel = channels.get(channelId);
+ if (channel == null) {
+ log.warn("Unable to find any channel with ID {}, cannot send probe",
+ channelId);
+ return CompletableFuture.completedFuture(false);
+ }
+ return CompletableFuture.supplyAsync(() -> {
+ try {
+ doDummyMessage(channel);
+ return true;
+ } catch (StatusRuntimeException e) {
+ log.debug("Probe for {} failed", channelId);
+ log.debug("", e);
+ return false;
+ }
+ });
+ }
}