| commit | 3717e604d53e98b94f8172265edc30a15771cde4 | [log] [tgz] |
|---|---|---|
| author | Ray Milkey <ray@opennetworking.org> | Thu Feb 01 13:49:47 2018 -0800 |
| committer | Ray Milkey <ray@opennetworking.org> | Fri Feb 02 23:06:44 2018 +0000 |
| tree | d71210b671b77d484ee034c11733e28b3598f479 | |
| parent | 6735683cc36d2e29746988fbc2670ad616aa4ed5 [diff] |
SONAR suggestions - prevent truncation of arithmetic expressions Change-Id: I4694c0c3183b991a4f0db793f584bc77a5fb7d60
diff --git a/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/OpenFlowDeviceProvider.java b/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/OpenFlowDeviceProvider.java index 66ded21..b007af1 100644 --- a/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/OpenFlowDeviceProvider.java +++ b/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/OpenFlowDeviceProvider.java
@@ -419,7 +419,7 @@ //TODO consider renaming KBPS and MBPS (as they are used to convert by division) private static final long KBPS = 1_000; - private static final long MBPS = 1_000 * 1_000; + private static final long MBPS = 1_000L * 1_000L; private static final Frequency FREQ50 = Frequency.ofGHz(50); private static final Frequency FREQ191_7 = Frequency.ofGHz(191_700); private static final Frequency FREQ4_4 = Frequency.ofGHz(4_400);
diff --git a/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/PortStatsCollector.java b/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/PortStatsCollector.java index cb83948..a17a690 100644 --- a/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/PortStatsCollector.java +++ b/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/PortStatsCollector.java
@@ -36,7 +36,7 @@ private final Logger log = getLogger(getClass()); - private static final int SECONDS = 1000; + private static final long SECONDS = 1000L; private OpenFlowSwitch sw; private Timer timer;
diff --git a/providers/openflow/flow/src/main/java/org/onosproject/provider/of/flow/impl/FlowStatsCollector.java b/providers/openflow/flow/src/main/java/org/onosproject/provider/of/flow/impl/FlowStatsCollector.java index 6f24fd2..f2e7137 100644 --- a/providers/openflow/flow/src/main/java/org/onosproject/provider/of/flow/impl/FlowStatsCollector.java +++ b/providers/openflow/flow/src/main/java/org/onosproject/provider/of/flow/impl/FlowStatsCollector.java
@@ -35,7 +35,7 @@ private final Logger log = getLogger(getClass()); - public static final int SECONDS = 1000; + public static final long SECONDS = 1000L; private final OpenFlowSwitch sw; private Timer timer;
diff --git a/providers/openflow/flow/src/main/java/org/onosproject/provider/of/flow/impl/TableStatisticsCollector.java b/providers/openflow/flow/src/main/java/org/onosproject/provider/of/flow/impl/TableStatisticsCollector.java index ee3f0c9..73dabeb 100644 --- a/providers/openflow/flow/src/main/java/org/onosproject/provider/of/flow/impl/TableStatisticsCollector.java +++ b/providers/openflow/flow/src/main/java/org/onosproject/provider/of/flow/impl/TableStatisticsCollector.java
@@ -33,7 +33,7 @@ private final Logger log = getLogger(getClass()); - public static final int SECONDS = 1000; + public static final long SECONDS = 1000L; private final OpenFlowSwitch sw; private Timer timer;