commit 3423ba11a8e91830dbfd6d36c4e122b58012e498
author Jian Li <pyguni@gmail.com> Tue Sep 24 01:01:24 2019 +0900
committer Jian Li <pyguni@gmail.com> Wed Sep 25 00:24:40 2019 +0900
tree 88e48b7b54c82b24bc6e0a11126a16135f6a5de7
parent f7f01d106f9ef212a2c57bea0a2691ac56d043eb

Fix: improve logging level for openstacknode and openstacknetworking

Change-Id: Ic1f2d847e04b0d5c50fefcc9fc71ed3c053b1fa9

apps/openstacknetworking/app/src/main/java/org/onosproject/openstacknetworking/web/OpenstackManagementWebResource.java

diff --git a/apps/openstacknetworking/app/src/main/java/org/onosproject/openstacknetworking/web/OpenstackManagementWebResource.java b/apps/openstacknetworking/app/src/main/java/org/onosproject/openstacknetworking/web/OpenstackManagementWebResource.java
index 6d27da8..c6776c7 100644
--- a/apps/openstacknetworking/app/src/main/java/org/onosproject/openstacknetworking/web/OpenstackManagementWebResource.java
+++ b/apps/openstacknetworking/app/src/main/java/org/onosproject/openstacknetworking/web/OpenstackManagementWebResource.java
@@ -95,6 +95,9 @@
 
     private static final String SECURITY_GROUP_FLAG_REQUIRED = "Security Group flag is not specified";
 
+    private static final String AUTH_INFO_NOT_FOUND = "Auth info is not found";
+    private static final String AUTH_INFO_NOT_CORRECT = "Auth info is not correct";
+
     private static final String HTTP_HEADER_ACCEPT = "accept";
     private static final String HTTP_HEADER_VALUE_JSON = "application/json";
 
@@ -132,13 +135,15 @@
 
         Optional<OpenstackNode> node = osNodeAdminService.nodes(CONTROLLER).stream().findFirst();
         if (!node.isPresent()) {
-            throw new ItemNotFoundException("Auth info is not found");
+            log.error(AUTH_INFO_NOT_FOUND);
+            throw new ItemNotFoundException(AUTH_INFO_NOT_FOUND);
         }
 
         OSClient osClient = OpenstackNetworkingUtil.getConnectedClient(node.get());
 
         if (osClient == null) {
-            throw new ItemNotFoundException("Auth info is not correct");
+            log.error(AUTH_INFO_NOT_CORRECT);
+            throw new ItemNotFoundException(AUTH_INFO_NOT_CORRECT);
         }
 
         try {
@@ -407,6 +412,8 @@
     @Produces(MediaType.APPLICATION_JSON)
     public Response updateActiveStatus(@PathParam("flag") String flag) {
 
+        log.info("Update active status to {}", flag);
+
         if (FLAG_TRUE.equalsIgnoreCase(flag)) {
             osHaService.setActive(true);
         }
@@ -443,6 +450,8 @@
     @Produces(MediaType.APPLICATION_JSON)
     public Response updateActiveIp(@PathParam("ip") String ip) {
 
+        log.info("Update active IP address to {}", ip);
+
         osHaService.setActiveIp(IpAddress.valueOf(ip));
 
         return status(Response.Status.OK).build();