commit 335ab875d5fa8256f39651b1aeab3d02c2324035
author Charles Chan <rascov@gmail.com> Tue Feb 20 10:29:05 2018 -0800
committer Charles Chan <rascov@gmail.com> Tue Feb 20 10:29:05 2018 -0800
tree 782436f50128da38b61bbf47d7e34f6ab91af34d
parent 07e99ad13a0b8212e94f70fc033a487d08b9d2a5

Fix Sonar warning - remove redundant condition check

Change-Id: I53949ac17b83c9dc72669586a2c0193170fd4f74

apps/dhcprelay/src/main/java/org/onosproject/dhcprelay/Dhcp6HandlerUtil.java

diff --git a/apps/dhcprelay/src/main/java/org/onosproject/dhcprelay/Dhcp6HandlerUtil.java b/apps/dhcprelay/src/main/java/org/onosproject/dhcprelay/Dhcp6HandlerUtil.java
index 17456f9..dac5aac 100644
--- a/apps/dhcprelay/src/main/java/org/onosproject/dhcprelay/Dhcp6HandlerUtil.java
+++ b/apps/dhcprelay/src/main/java/org/onosproject/dhcprelay/Dhcp6HandlerUtil.java
@@ -138,7 +138,7 @@
 
         Boolean directConnFlag = directlyConnected(lq6Reply);
         ConnectPoint inPort = context.inPacket().receivedFrom();
-        if ((directConnFlag || (!directConnFlag && indirectDhcpServerIp == null))
+        if ((directConnFlag || indirectDhcpServerIp == null)
                 && !inPort.equals(dhcpServerConnectPoint)) {
             log.warn("Receiving port {} is not the same as server connect point {} for direct or indirect-null",
                      inPort, dhcpServerConnectPoint);