Bug Fixes for Kafka Application(patchset #2)
1. Coding Errors in both the Converters
2. Pom file needs an import for com.google.protobuf
3. Port Object can be null in DeviceEvent. Added a check in the DeviceEventConverter
Change-Id: I28fe7e388b31bec7971b4ab1f431a3520162b53e
diff --git a/apps/kafka-integration/app/src/main/java/org/onosproject/kafkaintegration/converter/LinkEventConverter.java b/apps/kafka-integration/app/src/main/java/org/onosproject/kafkaintegration/converter/LinkEventConverter.java
index 2d65537..a1db209 100644
--- a/apps/kafka-integration/app/src/main/java/org/onosproject/kafkaintegration/converter/LinkEventConverter.java
+++ b/apps/kafka-integration/app/src/main/java/org/onosproject/kafkaintegration/converter/LinkEventConverter.java
@@ -40,7 +40,7 @@
LinkEvent linkEvent = (LinkEvent) event;
- if (!linkEventSubtypeSupported(linkEvent)) {
+ if (!linkEventTypeSupported(linkEvent)) {
log.error("Unsupported Onos Event {}. There is no matching"
+ "proto Event type", linkEvent.type().toString());
return null;
@@ -49,9 +49,9 @@
return buildDeviceProtoMessage(linkEvent);
}
- private boolean linkEventSubtypeSupported(LinkEvent event) {
- LinkType[] kafkaLinkEvents = LinkType.values();
- for (LinkType linkEventType : kafkaLinkEvents) {
+ private boolean linkEventTypeSupported(LinkEvent event) {
+ LinkEventType[] kafkaLinkEvents = LinkEventType.values();
+ for (LinkEventType linkEventType : kafkaLinkEvents) {
if (linkEventType.name().equals(event.type().name())) {
return true;
}