commit 303e671d3b243b2c389968f01a1bef2505a2e30b
author Ray Milkey <ray@onlab.us> Fri Jul 17 14:06:21 2015 -0700
committer Gerrit Code Review <gerrit@onlab.us> Mon Jul 20 16:36:52 2015 +0000
tree 419632dba7a8547d9ce54791eb52373289e34712
parent a09c0ed8a2e652c26cbaf34f8147d3b65b30dff0

Refactor to use JAXRS URI builder and fix HTTP status for bad JSON

Change-Id: I696bdd4792b002391abe709c7a0e3e600ad50157

web/api/src/main/java/org/onosproject/rest/resources/IntentsWebResource.java

diff --git a/web/api/src/main/java/org/onosproject/rest/resources/IntentsWebResource.java b/web/api/src/main/java/org/onosproject/rest/resources/IntentsWebResource.java
index 967d477..9c3e76a 100644
--- a/web/api/src/main/java/org/onosproject/rest/resources/IntentsWebResource.java
+++ b/web/api/src/main/java/org/onosproject/rest/resources/IntentsWebResource.java
@@ -17,8 +17,6 @@
 
 import java.io.IOException;
 import java.io.InputStream;
-import java.net.URI;
-import java.net.URISyntaxException;
 import java.util.Objects;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
@@ -30,8 +28,11 @@
 import javax.ws.rs.Path;
 import javax.ws.rs.PathParam;
 import javax.ws.rs.Produces;
+import javax.ws.rs.core.Context;
 import javax.ws.rs.core.MediaType;
 import javax.ws.rs.core.Response;
+import javax.ws.rs.core.UriBuilder;
+import javax.ws.rs.core.UriInfo;
 
 import org.onosproject.core.ApplicationId;
 import org.onosproject.core.CoreService;
@@ -59,6 +60,9 @@
 
 @Path("intents")
 public class IntentsWebResource extends AbstractWebResource {
+    @Context
+    UriInfo uriInfo;
+
     private static final Logger log = getLogger(IntentsWebResource.class);
     private static final int WITHDRAW_EVENT_TIMEOUT_SECONDS = 5;
 
@@ -194,20 +198,21 @@
     @Consumes(MediaType.APPLICATION_JSON)
     @Produces(MediaType.APPLICATION_JSON)
     public Response createIntent(InputStream stream) {
-        URI location;
         try {
             IntentService service = get(IntentService.class);
             ObjectNode root = (ObjectNode) mapper().readTree(stream);
             Intent intent = codec(Intent.class).decode(root, this);
             service.submit(intent);
-            location = new URI(Short.toString(intent.appId().id()) + "/"
-                    + Long.toString(intent.id().fingerprint()));
-        } catch (IOException | URISyntaxException ex) {
-            return Response.status(Response.Status.INTERNAL_SERVER_ERROR).build();
+            UriBuilder locationBuilder = uriInfo.getBaseUriBuilder()
+                    .path("intents")
+                    .path(Short.toString(intent.appId().id()))
+                    .path(Long.toString(intent.id().fingerprint()));
+            return Response
+                    .created(locationBuilder.build())
+                    .build();
+        } catch (IOException ioe) {
+            throw new IllegalArgumentException(ioe);
         }
-        return Response
-                .created(location)
-                .build();
     }
 
 }