commit 2c6b7efa8751676612e15a1b89b9ab341078aca3
author Ayaka Koshibe <ayaka@onlab.us> Tue Apr 28 17:18:05 2015 -0700
committer Gerrit Code Review <gerrit@onlab.us> Wed Apr 29 19:09:34 2015 +0000
tree e27bfdfda060dc8d7ec208d35d0ad346fecb6417
parent 41aff9fb4a36bb237f7e38b4bfdb6ac762784e2e

Fix for NPE in entry removal updates.

Reference: ONOS-1785

Change-Id: I146e6cbb39b2fdc36cec3e2df1b883f578f0200a

core/store/dist/src/main/java/org/onosproject/store/consistent/impl/DefaultDatabaseState.java

diff --git a/core/store/dist/src/main/java/org/onosproject/store/consistent/impl/DefaultDatabaseState.java b/core/store/dist/src/main/java/org/onosproject/store/consistent/impl/DefaultDatabaseState.java
index bad3782..a907091 100644
--- a/core/store/dist/src/main/java/org/onosproject/store/consistent/impl/DefaultDatabaseState.java
+++ b/core/store/dist/src/main/java/org/onosproject/store/consistent/impl/DefaultDatabaseState.java
@@ -30,7 +30,6 @@
 import org.onosproject.store.service.Transaction;
 import org.onosproject.store.service.Versioned;
 import org.onosproject.store.service.DatabaseUpdate.Type;
-
 import com.google.common.base.Objects;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableSet;
@@ -57,7 +56,7 @@
      * The presence of a entry in this map indicates that element is
      * participating in a transaction and is currently locked for updates.
      */
-    private Map<String, Map<String, Pair<Long, byte[]>>> locks;
+    private Map<String, Map<String, Update>> locks;
 
     @Initializer
     @Override
@@ -275,7 +274,7 @@
         return tables.computeIfAbsent(tableName, name -> Maps.newConcurrentMap());
     }
 
-    private Map<String, Pair<Long, byte[]>> getLockMap(String tableName) {
+    private Map<String, Update> getLockMap(String tableName) {
         return locks.computeIfAbsent(tableName, name -> Maps.newConcurrentMap());
     }
 
@@ -305,18 +304,18 @@
     }
 
     private void doProvisionalUpdate(DatabaseUpdate update, long transactionId) {
-        Map<String, Pair<Long, byte[]>> lockMap = getLockMap(update.tableName());
+        Map<String, Update> lockMap = getLockMap(update.tableName());
         switch (update.type()) {
         case PUT:
         case PUT_IF_ABSENT:
         case PUT_IF_VERSION_MATCH:
         case PUT_IF_VALUE_MATCH:
-            lockMap.put(update.key(), Pair.of(transactionId, update.value()));
+            lockMap.put(update.key(), new Update(transactionId, update.value()));
             break;
         case REMOVE:
         case REMOVE_IF_VERSION_MATCH:
         case REMOVE_IF_VALUE_MATCH:
-            lockMap.put(update.key(), null);
+            lockMap.put(update.key(), new Update(transactionId, null));
             break;
         default:
             throw new IllegalStateException("Unsupported type: " + update.type());
@@ -327,8 +326,8 @@
         String tableName = update.tableName();
         String key = update.key();
         Type type = update.type();
-        Pair<Long, byte[]> provisionalUpdate = getLockMap(tableName).get(key);
-        if (Objects.equal(transactionId, provisionalUpdate.getLeft()))  {
+        Update provisionalUpdate = getLockMap(tableName).get(key);
+        if (Objects.equal(transactionId, provisionalUpdate.transactionId()))  {
             getLockMap(tableName).remove(key);
         } else {
             return;
@@ -339,7 +338,7 @@
         case PUT_IF_ABSENT:
         case PUT_IF_VERSION_MATCH:
         case PUT_IF_VALUE_MATCH:
-            put(tableName, key, provisionalUpdate.getRight());
+            put(tableName, key, provisionalUpdate.value());
             break;
         case REMOVE:
         case REMOVE_IF_VERSION_MATCH:
@@ -354,18 +353,18 @@
     private void undoProvisionalUpdate(DatabaseUpdate update, long transactionId) {
         String tableName = update.tableName();
         String key = update.key();
-        Pair<Long, byte[]> provisionalUpdate = getLockMap(tableName).get(key);
+        Update provisionalUpdate = getLockMap(tableName).get(key);
         if (provisionalUpdate == null) {
             return;
         }
-        if (Objects.equal(transactionId, provisionalUpdate.getLeft()))  {
+        if (Objects.equal(transactionId, provisionalUpdate.transactionId()))  {
             getLockMap(tableName).remove(key);
         }
     }
 
     private boolean isLockedByAnotherTransaction(String tableName, String key, long transactionId) {
-        Pair<Long, byte[]> update = getLockMap(tableName).get(key);
-        return update != null && !Objects.equal(transactionId, update.getLeft());
+        Update update = getLockMap(tableName).get(key);
+        return update != null && !Objects.equal(transactionId, update.transactionId());
     }
 
     private boolean isLockedForUpdates(String tableName, String key) {
@@ -375,4 +374,22 @@
     private boolean areTransactionsInProgress(String tableName) {
         return !getLockMap(tableName).isEmpty();
     }
+
+    private class Update {
+        private final long transactionId;
+        private final byte[] value;
+
+        public Update(long txId, byte[] value) {
+            this.transactionId = txId;
+            this.value = value;
+        }
+
+        public long transactionId() {
+            return this.transactionId;
+        }
+
+        public byte[] value() {
+            return this.value;
+        }
+    }
 }