Revamped ClusterCommunicationService API
Change-Id: I9326369de3d2413b0882b324979d10483c093de9
diff --git a/core/store/dist/src/main/java/org/onosproject/store/group/impl/DistributedGroupStore.java b/core/store/dist/src/main/java/org/onosproject/store/group/impl/DistributedGroupStore.java
index 51b4111..ae1669b 100644
--- a/core/store/dist/src/main/java/org/onosproject/store/group/impl/DistributedGroupStore.java
+++ b/core/store/dist/src/main/java/org/onosproject/store/group/impl/DistributedGroupStore.java
@@ -382,17 +382,13 @@
GroupStoreMessage groupOp = GroupStoreMessage.
createGroupAddRequestMsg(groupDesc.deviceId(),
groupDesc);
- ClusterMessage message = new ClusterMessage(
- clusterService.getLocalNode().id(),
- GroupStoreMessageSubjects.
- REMOTE_GROUP_OP_REQUEST,
- kryoBuilder.build().serialize(groupOp));
- if (!clusterCommunicator.unicast(message,
- mastershipService.
- getMasterFor(
- groupDesc.deviceId()))) {
+
+ if (!clusterCommunicator.unicast(groupOp,
+ GroupStoreMessageSubjects.REMOTE_GROUP_OP_REQUEST,
+ m -> kryoBuilder.build().serialize(m),
+ mastershipService.getMasterFor(groupDesc.deviceId()))) {
log.warn("Failed to send request to master: {} to {}",
- message,
+ groupOp,
mastershipService.getMasterFor(groupDesc.deviceId()));
//TODO: Send Group operation failure event
}
@@ -472,16 +468,13 @@
type,
newBuckets,
newAppCookie);
- ClusterMessage message =
- new ClusterMessage(clusterService.getLocalNode().id(),
- GroupStoreMessageSubjects.
- REMOTE_GROUP_OP_REQUEST,
- kryoBuilder.build().serialize(groupOp));
- if (!clusterCommunicator.unicast(message,
- mastershipService.
- getMasterFor(deviceId))) {
+
+ if (!clusterCommunicator.unicast(groupOp,
+ GroupStoreMessageSubjects.REMOTE_GROUP_OP_REQUEST,
+ m -> kryoBuilder.build().serialize(m),
+ mastershipService.getMasterFor(deviceId))) {
log.warn("Failed to send request to master: {} to {}",
- message,
+ groupOp,
mastershipService.getMasterFor(deviceId));
//TODO: Send Group operation failure event
}
@@ -584,16 +577,13 @@
GroupStoreMessage groupOp = GroupStoreMessage.
createGroupDeleteRequestMsg(deviceId,
appCookie);
- ClusterMessage message =
- new ClusterMessage(clusterService.getLocalNode().id(),
- GroupStoreMessageSubjects.
- REMOTE_GROUP_OP_REQUEST,
- kryoBuilder.build().serialize(groupOp));
- if (!clusterCommunicator.unicast(message,
- mastershipService.
- getMasterFor(deviceId))) {
+
+ if (!clusterCommunicator.unicast(groupOp,
+ GroupStoreMessageSubjects.REMOTE_GROUP_OP_REQUEST,
+ m -> kryoBuilder.build().serialize(m),
+ mastershipService.getMasterFor(deviceId))) {
log.warn("Failed to send request to master: {} to {}",
- message,
+ groupOp,
mastershipService.getMasterFor(deviceId));
//TODO: Send Group operation failure event
}