revisit checkstyle buck rule
- checkstyle execution only needs to depend on
input source files (filename list)
Change-Id: I070b9b5a317a8f777cfced7b3873cda5b7acc221
diff --git a/bucklets/onos.bucklet b/bucklets/onos.bucklet
index 6341896..d6eb053 100644
--- a/bucklets/onos.bucklet
+++ b/bucklets/onos.bucklet
@@ -21,7 +21,7 @@
jar_target = None,
):
- if srcs and jar_target:
+ if srcs:
base = get_base_path()
files = '%s\n%s\n' % (name, base) + '\n'.join(['%s/%s' % (base, s) for s in srcs])
@@ -35,7 +35,7 @@
sh_test(
name = name + '-checkstyle',
test = '//tools/build/conf:start-buck-daemon',
- deps = [ jar_target,
+ deps = [ ':' + name + '-checkstyle-files',
'//tools/build/conf:onos-java-header',
'//tools/build/conf:onos-build-conf', ],
args = [
@@ -198,7 +198,6 @@
checkstyle(
name = name,
srcs = srcs,
- jar_target = ':'+ name,
)
if do_javadocs:
@@ -287,9 +286,8 @@
)
checkstyle(
- name = name + '-tests' + '-checkstyle',
+ name = name + '-tests',
srcs = test_srcs,
- jar_target = ':' + name + '-tests',
)
sonar(