Fix high priority findbugs reported issues
Fixed some code that was reporting findbugs errors
Implemented a suppression mechanism for findbugs
reported errors and a suppression file.
Change-Id: Ie8a2e84cc57ec6ddfa14d782ee89feb095b9dd59
diff --git a/utils/misc/src/main/java/org/onlab/packet/ONOSLLDP.java b/utils/misc/src/main/java/org/onlab/packet/ONOSLLDP.java
index 0b33c45..5b3902a 100644
--- a/utils/misc/src/main/java/org/onlab/packet/ONOSLLDP.java
+++ b/utils/misc/src/main/java/org/onlab/packet/ONOSLLDP.java
@@ -19,6 +19,7 @@
import org.apache.commons.lang.ArrayUtils;
import java.nio.ByteBuffer;
+import java.nio.charset.StandardCharsets;
/**
* ONOS LLDP containing organizational TLV for ONOS device dicovery.
@@ -141,7 +142,7 @@
public String getNameString() {
LLDPOrganizationalTLV tlv = getNameTLV();
if (tlv != null) {
- return new String(tlv.getInfoString());
+ return new String(tlv.getInfoString(), StandardCharsets.UTF_8);
}
return null;
}
@@ -149,7 +150,7 @@
public String getDeviceString() {
LLDPOrganizationalTLV tlv = getDeviceTLV();
if (tlv != null) {
- return new String(tlv.getInfoString());
+ return new String(tlv.getInfoString(), StandardCharsets.UTF_8);
}
return null;
}