commit 239f96bd544537e3b92fd4cfa24666ce283b3b1c
author Ray Milkey <ray@opennetworking.org> Wed Nov 28 09:31:47 2018 -0800
committer Thomas Vachuska <tom@opennetworking.org> Wed Nov 28 18:48:18 2018 +0000
tree d88eb24f06e2ec082351c1bb4faba5a940e5426a
parent 4747a1824de767f24cd0da11298b87b0024bf356

Sonar suggested fix - lock creation of singleton

Change-Id: I2139dff76207efcb6b98c6651037f6abdb17bd6b

drivers/odtn-driver/src/main/java/org/onosproject/drivers/odtn/impl/OpenConfigConnectionCache.java

diff --git a/drivers/odtn-driver/src/main/java/org/onosproject/drivers/odtn/impl/OpenConfigConnectionCache.java b/drivers/odtn-driver/src/main/java/org/onosproject/drivers/odtn/impl/OpenConfigConnectionCache.java
index 5d2c7e7..95adebc 100644
--- a/drivers/odtn-driver/src/main/java/org/onosproject/drivers/odtn/impl/OpenConfigConnectionCache.java
+++ b/drivers/odtn-driver/src/main/java/org/onosproject/drivers/odtn/impl/OpenConfigConnectionCache.java
@@ -41,8 +41,9 @@
     private Map<DeviceId, Set<FlowRule>> smp = Collections.synchronizedMap(mp);
 
     private static OpenConfigConnectionCache cache = null;
+    private static final Object CACHE_LOCK = new Object();
 
-    //banning public contraction
+    //banning public construction
     private OpenConfigConnectionCache() {
     }
 
@@ -53,8 +54,10 @@
      * @return single instance of cache
      */
     public static OpenConfigConnectionCache init() {
-        if (cache == null) {
-            cache = new OpenConfigConnectionCache();
+        synchronized (CACHE_LOCK) {
+            if (cache == null) {
+                cache = new OpenConfigConnectionCache();
+            }
         }
         return cache;
     }