[WEB GUI] Fixed tests: (345 test passing, 21 skipped).
Change-Id: Idf24ac6ab599664a052c7cc860a554db82953a79
diff --git a/web/gui/src/main/webapp/tests/app/view/topo/topoEvent-spec.js b/web/gui/src/main/webapp/tests/app/view/topo/topoEvent-spec.js
index 183f571..ff2210c 100644
--- a/web/gui/src/main/webapp/tests/app/view/topo/topoEvent-spec.js
+++ b/web/gui/src/main/webapp/tests/app/view/topo/topoEvent-spec.js
@@ -31,13 +31,13 @@
bns = ButtonService;
}));
- xit('should define TopoEventService', function () {
+ it('should define TopoEventService', function () {
expect(tes).toBeDefined();
});
- xit('should define api functions', function () {
+ it('should define api functions', function () {
expect(fs.areFunctions(tes, [
- 'start', 'stop'
+ 'start', 'stop', 'bindHandlers'
])).toBeTruthy();
});
diff --git a/web/gui/src/main/webapp/tests/app/view/topo/topoForce-spec.js b/web/gui/src/main/webapp/tests/app/view/topo/topoForce-spec.js
index 43c2394..101dda8 100644
--- a/web/gui/src/main/webapp/tests/app/view/topo/topoForce-spec.js
+++ b/web/gui/src/main/webapp/tests/app/view/topo/topoForce-spec.js
@@ -31,11 +31,11 @@
bns = ButtonService;
}));
- xit('should define TopoForceService', function () {
+ it('should define TopoForceService', function () {
expect(tfs).toBeDefined();
});
- xit('should define api functions', function () {
+ it('should define api functions', function () {
expect(fs.areFunctions(tfs, [
'initForce', 'newDim', 'destroyForce',
@@ -43,9 +43,9 @@
'togglePorts', 'toggleOffline',
'cycleDeviceLabels', 'unpin', 'showMastership', 'showBadLinks',
- 'addDevice', 'updateDevice', 'removeDevice',
- 'addHost', 'updateHost', 'removeHost',
- 'addLink', 'updateLink', 'removeLink'
+ 'resetAllLocations', 'addDevice', 'updateDevice', 'removeDevice',
+ 'addHost', 'updateHost', 'moveHost', 'removeHost',
+ 'addLink', 'updateLink', 'removeLink', 'topoStartDone'
])).toBeTruthy();
});
diff --git a/web/gui/src/main/webapp/tests/app/view/topo/topoInst-spec.js b/web/gui/src/main/webapp/tests/app/view/topo/topoInst-spec.js
index 5507966..6458b39 100644
--- a/web/gui/src/main/webapp/tests/app/view/topo/topoInst-spec.js
+++ b/web/gui/src/main/webapp/tests/app/view/topo/topoInst-spec.js
@@ -28,11 +28,11 @@
tis = TopoInstService;
}));
- xit('should define TopoInstService', function () {
+ it('should define TopoInstService', function () {
expect(tis).toBeDefined();
});
- xit('should define api functions', function () {
+ it('should define api functions', function () {
expect(fs.areFunctions(tis, [
'initInst', 'destroyInst',
'addInstance', 'updateInstance', 'removeInstance',
diff --git a/web/gui/src/main/webapp/tests/app/view/topo/topoModel-spec.js b/web/gui/src/main/webapp/tests/app/view/topo/topoModel-spec.js
index 93fb8fd..0d1f8a5 100644
--- a/web/gui/src/main/webapp/tests/app/view/topo/topoModel-spec.js
+++ b/web/gui/src/main/webapp/tests/app/view/topo/topoModel-spec.js
@@ -207,10 +207,10 @@
expect(tms).toBeDefined();
});
- xit('should define api functions', function () {
+ it('should define api functions', function () {
expect(fs.areFunctions(tms, [
'initModel', 'newDim', 'destroyModel',
- 'positionNode', 'createDeviceNode', 'createHostNode',
+ 'positionNode', 'resetAllLocations', 'createDeviceNode', 'createHostNode',
'createHostLink', 'createLink',
'coordFromLngLat', 'lngLatFromCoord',
'findLink', 'findLinkById', 'findDevices',
@@ -406,7 +406,7 @@
expect(link.class).toEqual('link');
expect(link.fromSource).toBe(linkData);
expect(link.type()).toEqual('zoo');
- expect(link.online()).toEqual(true);
+ expect(link.online()).toEqual(true); // this is the condition failing
expect(link.linkWidth()).toEqual(1.5);
});
diff --git a/web/gui/src/main/webapp/tests/app/view/topo/topoPanel-spec.js b/web/gui/src/main/webapp/tests/app/view/topo/topoPanel-spec.js
index 2f89f44..c0195ec 100644
--- a/web/gui/src/main/webapp/tests/app/view/topo/topoPanel-spec.js
+++ b/web/gui/src/main/webapp/tests/app/view/topo/topoPanel-spec.js
@@ -57,7 +57,7 @@
expect(tps).toBeDefined();
});
- xit('should define api functions', function () {
+ it('should define api functions', function () {
expect(fs.areFunctions(tps, [
'initPanels',
'destroyPanels',
@@ -65,6 +65,7 @@
'showSummary',
'toggleSummary',
+ 'hideSummary',
'toggleUseDetailsFlag',
'displaySingle',
@@ -74,8 +75,6 @@
'displaySomething',
'addAction',
- 'hideSummaryPanel',
-
'detailVisible',
'summaryVisible'
])).toBeTruthy();
diff --git a/web/gui/src/main/webapp/tests/app/view/topo/topoSelect-spec.js b/web/gui/src/main/webapp/tests/app/view/topo/topoSelect-spec.js
index 8d372bd..f6a5157 100644
--- a/web/gui/src/main/webapp/tests/app/view/topo/topoSelect-spec.js
+++ b/web/gui/src/main/webapp/tests/app/view/topo/topoSelect-spec.js
@@ -35,15 +35,15 @@
expect(tss).toBeDefined();
});
- xit('should define api functions', function () {
+ it('should define api functions', function () {
expect(fs.areFunctions(tss, [
'initSelect', 'destroySelect',
'showDetails',
'nodeMouseOver', 'nodeMouseOut', 'selectObject', 'deselectObject',
- 'deselectAll',
+ 'deselectAll', 'updateDetail',
'hovered', 'selectOrder',
- 'validateSelectionContext',
- 'clickConsumed'
+ 'somethingSelected',
+ 'clickConsumed', 'selectionContext'
])).toBeTruthy();
});
diff --git a/web/gui/src/main/webapp/tests/app/view/topo/topoToolbar-spec.js b/web/gui/src/main/webapp/tests/app/view/topo/topoToolbar-spec.js
index fd04a51..cb049e4 100644
--- a/web/gui/src/main/webapp/tests/app/view/topo/topoToolbar-spec.js
+++ b/web/gui/src/main/webapp/tests/app/view/topo/topoToolbar-spec.js
@@ -35,14 +35,17 @@
ps.init();
}));
- xit('should define TopoToolbarService', function () {
+ it('should define TopoToolbarService', function () {
expect(ttbs).toBeDefined();
});
xit('should define api functions', function () {
+ // FIXME
+ // areFunctions check that each key of the object is a fn, what if it is a string or whatever?
expect(fs.areFunctions(ttbs, [
'init', 'createToolbar', 'destroyToolbar',
- 'keyListener', 'toggleToolbar'
+ 'keyListener', 'toggleToolbar', 'setDefaultOverlay',
+ 'fnkey'
])).toBeTruthy();
});
diff --git a/web/gui/src/main/webapp/tests/app/view/topo/topoTraffic-spec.js b/web/gui/src/main/webapp/tests/app/view/topo/topoTraffic-spec.js
index b1d0bf8..16686e1 100644
--- a/web/gui/src/main/webapp/tests/app/view/topo/topoTraffic-spec.js
+++ b/web/gui/src/main/webapp/tests/app/view/topo/topoTraffic-spec.js
@@ -32,15 +32,23 @@
expect(tts).toBeDefined();
});
- xit('should define api functions', function () {
+ it('should define api functions', function () {
expect(fs.areFunctions(tts, [
- 'initTraffic', 'destroyTraffic', 'showTraffic',
- 'cancelTraffic', 'requestTrafficForMode',
- 'showRelatedIntentsAction', 'addHostIntentAction',
- 'addMultiSourceIntentAction', 'showDeviceLinkFlowsAction',
- 'showNextIntentAction', 'showPrevIntentAction',
- 'showSelectedIntentTrafficAction', 'showAllTrafficAction'
+ 'initTraffic',
+ 'destroyTraffic',
+ 'cancelTraffic',
+ 'showAllFlowTraffic',
+ 'showAllPortTraffic',
+ 'showDeviceLinkFlows',
+ 'showRelatedIntents',
+ 'showPrevIntent',
+ 'showNextIntent',
+ 'showSelectedIntentTraffic',
+ 'selectIntent',
+ 'requestTrafficForMode',
+ 'addHostIntent',
+ 'addMultiSourceIntent',
])).toBeTruthy();
});