commit 2014cdb79f9bf5dd73caabcbd1107fc72ae36986
author Ray Milkey <ray@opennetworking.org> Wed May 16 09:12:24 2018 -0700
committer Thomas Vachuska <tom@opennetworking.org> Wed May 16 17:11:45 2018 +0000
tree 65321cbd790e5c8a0712e7693302767c0a4a7190
parent a74bdba108ea88097075d5ba87ffe2a7ace95aee

Sonar objects to non-static members in servlet objects

Change-Id: I4544fcececda5146c03ba1d551cc0a119b29c502

web/gui/src/main/java/org/onosproject/ui/impl/UiWebSocketServlet.java

diff --git a/web/gui/src/main/java/org/onosproject/ui/impl/UiWebSocketServlet.java b/web/gui/src/main/java/org/onosproject/ui/impl/UiWebSocketServlet.java
index 2db0c61..650f727 100644
--- a/web/gui/src/main/java/org/onosproject/ui/impl/UiWebSocketServlet.java
+++ b/web/gui/src/main/java/org/onosproject/ui/impl/UiWebSocketServlet.java
@@ -40,12 +40,12 @@
     private static UiWebSocketServlet instance;
     private static final Object INSTANCE_LOCK = new Object();
 
-    private ServiceDirectory directory = new DefaultServiceDirectory();
+    private static ServiceDirectory directory = new DefaultServiceDirectory();
 
     private final Set<UiWebSocket> sockets = Sets.newConcurrentHashSet();
     private final Timer timer = new Timer();
     private final TimerTask pruner = new Pruner();
-    private boolean isStopped = false;
+    private static boolean isStopped = false;
 
     /**
      * Closes all currently open UI web-sockets.
@@ -53,7 +53,7 @@
     public static void closeAll() {
         synchronized (INSTANCE_LOCK) {
             if (instance != null) {
-                instance.isStopped = true;
+                isStopped = true;
                 instance.sockets.forEach(UiWebSocket::close);
                 instance.sockets.clear();
                 instance.pruner.cancel();