commit 1cdfd8edc72b9162f2f0535bd72515c8114ebbc9
author Ray Milkey <ray@onlab.us> Fri Apr 10 15:20:03 2015 -0700
committer Gerrit Code Review <gerrit@onlab.us> Sat Apr 11 00:40:20 2015 +0000
tree 175b8b568fbb8dc5db24467a5f7c170676263cb5
parent fcf861a06a70517de14084d6862158325c723b3b

More ONOS-1612 - Fix NPEs if compenent lookup fails

Change-Id: Icc881cc79e75b7c44bcaa925b266396a93b60dbe

cli/src/main/java/org/onosproject/cli/cfg/ComponentPropertyNameCompleter.java

diff --git a/cli/src/main/java/org/onosproject/cli/cfg/ComponentPropertyNameCompleter.java b/cli/src/main/java/org/onosproject/cli/cfg/ComponentPropertyNameCompleter.java
index db015f1..5b72493 100644
--- a/cli/src/main/java/org/onosproject/cli/cfg/ComponentPropertyNameCompleter.java
+++ b/cli/src/main/java/org/onosproject/cli/cfg/ComponentPropertyNameCompleter.java
@@ -16,6 +16,7 @@
 package org.onosproject.cli.cfg;
 
 import java.util.List;
+import java.util.Set;
 import java.util.SortedSet;
 
 import org.apache.felix.service.command.CommandSession;
@@ -24,6 +25,7 @@
 import org.apache.karaf.shell.console.completer.ArgumentCompleter;
 import org.apache.karaf.shell.console.completer.StringsCompleter;
 import org.onosproject.cfg.ComponentConfigService;
+import org.onosproject.cfg.ConfigProperty;
 import org.onosproject.cli.AbstractShellCommand;
 
 /**
@@ -46,8 +48,11 @@
                 AbstractShellCommand.get(ComponentConfigService.class);
 
         SortedSet<String> strings = delegate.getStrings();
-        service.getProperties(componentName)
-                .forEach(property -> strings.add(property.name()));
+        Set<ConfigProperty> properties =
+            service.getProperties(componentName);
+        if (properties != null) {
+            properties.forEach(property -> strings.add(property.name()));
+        }
 
         // Now let the completer do the work for figuring out what to offer.
         return delegate.complete(buffer, cursor, candidates);