Bug fixes for ONOS-3509
- Forwarding behavior added to {Device,Link}Store by ONOS-490
cauesed false update information sent from ONOS node, which has been detached from the cluster,
to be accepted by rest of the cluster after the detached node has rejoined cluster.
- Fix for periodic mastership check was left out
when MastershipService#requestRoleFor(..) return value was changed to Future.
- Fix for triggerProbe() related messages getting dropped,
right after STANDBY -> MASTER role change.
- Local state (connectedDevices) was preventing
vertical (Core -> switch) Mastership state synchronization.
- Various debug log, comment added during investigation.
Change-Id: I777beadf04db8a879830a07bfdc7ab0e2279f190
diff --git a/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/OpenFlowDeviceProvider.java b/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/OpenFlowDeviceProvider.java
index 0950166..a1386ae 100644
--- a/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/OpenFlowDeviceProvider.java
+++ b/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/OpenFlowDeviceProvider.java
@@ -268,7 +268,7 @@
LOG.error("Unknown Mastership state : {}", newRole);
}
- LOG.debug("Accepting mastership role change for device {}", deviceId);
+ LOG.debug("Accepting mastership role change to {} for device {}", newRole, deviceId);
}
@@ -297,7 +297,7 @@
}
private void pushPortMetrics(Dpid dpid, List<OFPortStatsEntry> portStatsEntries) {
- DeviceId deviceId = DeviceId.deviceId(dpid.uri(dpid));
+ DeviceId deviceId = DeviceId.deviceId(Dpid.uri(dpid));
Collection<PortStatistics> stats = buildPortStatistics(deviceId, portStatsEntries);
providerService.updatePortStatistics(deviceId, stats);
}
@@ -434,6 +434,7 @@
@Override
public void switchChanged(Dpid dpid) {
+ LOG.debug("switchChanged({})", dpid);
if (providerService == null) {
return;
}
@@ -442,17 +443,21 @@
if (sw == null) {
return;
}
- providerService.updatePorts(did, buildPortDescriptions(sw));
+ final List<PortDescription> ports = buildPortDescriptions(sw);
+ LOG.debug("switchChanged({}) {}", did, ports);
+ providerService.updatePorts(did, ports);
}
@Override
public void portChanged(Dpid dpid, OFPortStatus status) {
+ LOG.debug("portChanged({},{})", dpid, status);
PortDescription portDescription = buildPortDescription(status);
providerService.portStatusChanged(deviceId(uri(dpid)), portDescription);
}
@Override
public void receivedRoleReply(Dpid dpid, RoleState requested, RoleState response) {
+ LOG.debug("receivedRoleReply({},{},{})", dpid, requested, response);
MastershipRole request = roleOf(requested);
MastershipRole reply = roleOf(response);
providerService.receivedRoleReply(deviceId(uri(dpid)), request, reply);
@@ -503,7 +508,7 @@
LOG.debug("Ports Of{}", portsOf);
portsOf.forEach(
op -> {
- portDescs.add(buildPortDescription(type, (OFObject) op));
+ portDescs.add(buildPortDescription(type, op));
}
);
});