commit 153dbd5b7fd0727f50766771e8ec5c669a00b9e2
author Jordan Halterman <jordan@opennetworking.org> Thu Dec 21 11:08:19 2017 -0800
committer Jordan Halterman <jordan@opennetworking.org> Thu Dec 21 20:21:51 2017 +0000
tree b6e7b9e1153b8f3855055d51cbdfd3cd7f1f4a52
parent e743babd01c5cbfc3f580a4c77993bc7047d0846

Ensure TCP_NODELAY is properly configured on Netty channels

Change-Id: I21ba4f048d609a56ceff4b4ae2cb0c02e6d57bf2

core/store/dist/src/main/java/org/onosproject/store/cluster/messaging/impl/NettyMessagingManager.java

diff --git a/core/store/dist/src/main/java/org/onosproject/store/cluster/messaging/impl/NettyMessagingManager.java b/core/store/dist/src/main/java/org/onosproject/store/cluster/messaging/impl/NettyMessagingManager.java
index 0359bae..82ba95f 100644
--- a/core/store/dist/src/main/java/org/onosproject/store/cluster/messaging/impl/NettyMessagingManager.java
+++ b/core/store/dist/src/main/java/org/onosproject/store/cluster/messaging/impl/NettyMessagingManager.java
@@ -486,8 +486,6 @@
         bootstrap.option(ChannelOption.SO_SNDBUF, 1048576);
         bootstrap.option(ChannelOption.CONNECT_TIMEOUT_MILLIS, 1000);
         bootstrap.group(clientGroup);
-        // TODO: Make this faster:
-        // http://normanmaurer.me/presentations/2014-facebook-eng-netty/slides.html#37.0
         bootstrap.channel(clientChannelClass);
         bootstrap.option(ChannelOption.SO_KEEPALIVE, true);
         bootstrap.remoteAddress(endpoint.host().toInetAddress(), endpoint.port());
@@ -504,7 +502,8 @@
         b.childOption(ChannelOption.WRITE_BUFFER_WATER_MARK,
                 new WriteBufferWaterMark(8 * 1024, 32 * 1024));
         b.option(ChannelOption.SO_RCVBUF, 1048576);
-        b.option(ChannelOption.TCP_NODELAY, true);
+        b.childOption(ChannelOption.SO_KEEPALIVE, true);
+        b.childOption(ChannelOption.TCP_NODELAY, true);
         b.childOption(ChannelOption.ALLOCATOR, PooledByteBufAllocator.DEFAULT);
         b.group(serverGroup, clientGroup);
         b.channel(serverChannelClass);