tree f2409a7462d81e7aafd28c04d43d1664360c70bd
parent 9507d2ab8b64394caff610432138d86e5b3a43a9
author HIGUCHI Yuta <y-higuchi@ak.jp.nec.com> 1448512952 -0800
committer Yuta HIGUCHI <y-higuchi@onlab.us> 1449032171 +0000

ONOS-3472 Fixing ConsistentMap key equality

- ConsistentMap's key equality is based on serialized byte[].
  2 Problems fixed by this patch:

 (1) By caching Key -> String representation,
     Cache will use Key's Object#equals for look up,
     which can possibly have different equality than byte[] equality,
     leading to wrong String to be used as a key in backend Database.

     Fixed by reversing the mapping.

 (2) Similar issues with keySet(), entrySet()
     Set based on reference equality needs to be used to avoid
     deduplication based on Object#equals

     Fixed by replacing Set implementation with MappingSet.

Change-Id: I1b727abd2614a9b72b5b1d02ecca2de26493adcc