commit 148ba2f86c350d8474ff9da9ecd6c00d08e84a17
author Brian O'Connor <bocon@onlab.us> Mon Jul 06 11:38:44 2015 -0700
committer Gerrit Code Review <gerrit@onlab.us> Mon Jul 06 20:05:34 2015 +0000
tree 3ee57be5e6d6a9e4254e51d3f420b891d735236f
parent c615485959cc9a1dc46649e2272e9922c9daf19b

Improving null safety of GossipIntentStore peer update function

Change-Id: I4f517d899c98f7c6cd0964465dfbcebae17363a3

core/store/dist/src/main/java/org/onosproject/store/intent/impl/GossipIntentStore.java

diff --git a/core/store/dist/src/main/java/org/onosproject/store/intent/impl/GossipIntentStore.java b/core/store/dist/src/main/java/org/onosproject/store/intent/impl/GossipIntentStore.java
index a884e7a..310d366 100644
--- a/core/store/dist/src/main/java/org/onosproject/store/intent/impl/GossipIntentStore.java
+++ b/core/store/dist/src/main/java/org/onosproject/store/intent/impl/GossipIntentStore.java
@@ -195,7 +195,7 @@
         NodeId origin = (data != null) ? data.origin() : null;
         if (master == null || origin == null) {
             log.warn("Intent {} has no home; master = {}, origin = {}",
-                     data.key(), master, origin);
+                     key, master, origin);
         }
 
         NodeId me = clusterService.getLocalNode().id();
@@ -208,8 +208,8 @@
         } else if (isOrigin) {
             return master != null ? ImmutableList.of(master) : getRandomNode();
         } else {
-            log.warn("Not master or origin for intent {}", data.key());
-            return ImmutableList.of(master);
+            log.warn("Not master or origin for intent {}", key);
+            return master != null ? ImmutableList.of(master) : getRandomNode();
         }
     }