commit 12ceb7acdbd50f1fa812b1b27553e28630101f24
author Ray Milkey <ray@opennetworking.org> Tue Jun 05 12:45:04 2018 -0700
committer Yuta HIGUCHI <y-higuchi@opennetworking.org> Tue Jun 05 22:21:04 2018 +0000
tree 7d0fd54bfb9b81a27133e50bf78744338baad439
parent ad83ef9912d57f38e69564df92bb2d970095ca36

Fix ErrorProne reported problems with null checks on primitive types

Change-Id: I0e930370743be30cfb1e149535e53caf62947683

protocols/snmp/ctl/src/main/java/org/onosproject/snmp/ctl/DefaultSnmpDevice.java

diff --git a/protocols/snmp/ctl/src/main/java/org/onosproject/snmp/ctl/DefaultSnmpDevice.java b/protocols/snmp/ctl/src/main/java/org/onosproject/snmp/ctl/DefaultSnmpDevice.java
index 2442240..5104cb8 100644
--- a/protocols/snmp/ctl/src/main/java/org/onosproject/snmp/ctl/DefaultSnmpDevice.java
+++ b/protocols/snmp/ctl/src/main/java/org/onosproject/snmp/ctl/DefaultSnmpDevice.java
@@ -59,7 +59,7 @@
                              String username, String community) {
         this.protocol = GenericAddress.TYPE_UDP;
         this.snmpHost = checkNotNull(snmpHost, "SNMP Device IP cannot be null");
-        this.snmpPort = checkNotNull(snmpPort, "SNMP Device port cannot be null");
+        this.snmpPort = snmpPort;
         this.notificationProtocol = GenericAddress.TYPE_UDP;
         this.notificationPort = 0;
         this.username = username;
@@ -73,9 +73,8 @@
         this.protocol = snmpDeviceConfig.protocol();
         this.notificationProtocol = snmpDeviceConfig.notificationProtocol();
         this.snmpHost = checkNotNull(snmpDeviceConfig.ip().toString(), "SNMP Device IP cannot be null");
-        this.snmpPort = checkNotNull(snmpDeviceConfig.port(), "SNMP Device port cannot be null");
-        this.notificationPort = checkNotNull(snmpDeviceConfig.notificationPort(),
-                                          "SNMP Device notification port cannot be null");
+        this.snmpPort = snmpDeviceConfig.port();
+        this.notificationPort = snmpDeviceConfig.notificationPort();
         this.username = snmpDeviceConfig.username();
         this.community = snmpDeviceConfig.password();
         this.deviceId = createDeviceId();
@@ -86,7 +85,7 @@
         reachable = true;
         try {
             TransportMapping transport;
-            if (protocol == GenericAddress.TYPE_TCP) {
+            if (protocol.equals(GenericAddress.TYPE_TCP)) {
                 transport = new DefaultTcpTransportMapping();
             } else {
                 transport = new DefaultUdpTransportMapping();