commit 0d89ea342a8234e12d7c3cf73bd3ad64dd4a19ba
author Jordan Halterman <jordan@onlab.us> Tue Jun 13 10:42:36 2017 -0700
committer Ray Milkey <ray@onlab.us> Fri Jun 16 21:45:12 2017 +0000
tree 9b81321f80a417af39e005a9d589121e515fc95b
parent c939037f350fd1570f184670682eb50f40f7cb0c

Limit/validate string lengths for various identifiers to prevent DoS from large objects

Change-Id: Ib7c34ddf8bd161efdf8d00a50f3378f9b7366188

core/api/src/main/java/org/onosproject/cluster/NodeId.java

diff --git a/core/api/src/main/java/org/onosproject/cluster/NodeId.java b/core/api/src/main/java/org/onosproject/cluster/NodeId.java
index d4c4c2e..80e94dc 100644
--- a/core/api/src/main/java/org/onosproject/cluster/NodeId.java
+++ b/core/api/src/main/java/org/onosproject/cluster/NodeId.java
@@ -17,11 +17,15 @@
 
 import org.onlab.util.Identifier;
 
+import static com.google.common.base.Preconditions.checkArgument;
+
 /**
  * Controller cluster identity.
  */
 public final class NodeId extends Identifier<String> implements Comparable<NodeId> {
 
+    private static final int ID_MAX_LENGTH = 1024;
+
     /**
      * Constructor for serialization.
      */
@@ -36,6 +40,7 @@
      */
     public NodeId(String id) {
         super(id);
+        checkArgument(id.length() <= ID_MAX_LENGTH, "id exceeds maximum length " + ID_MAX_LENGTH);
     }
 
     /**