commit 0d33700d45a232b2077577d66fa420093a2811db
author Thomas Vachuska <tom@onlab.us> Wed May 04 10:00:18 2016 -0700
committer Gerrit Code Review <gerrit@onlab.us> Wed May 04 17:50:46 2016 +0000
tree e1a6a0fef095792a23c752537ab945cd7c031364
parent 9a8d16dbb8c9a270b01984d285747ee57e186109

Changed default borrow behaviour to simply get current cell definition if a reservation exists already.

Change-Id: I365233a78be6033d176e33c3c3b3ad33f791d85e

utils/warden/src/main/java/org/onlab/warden/Warden.java

diff --git a/utils/warden/src/main/java/org/onlab/warden/Warden.java b/utils/warden/src/main/java/org/onlab/warden/Warden.java
index 0469a7f..b1e4c71 100644
--- a/utils/warden/src/main/java/org/onlab/warden/Warden.java
+++ b/utils/warden/src/main/java/org/onlab/warden/Warden.java
@@ -49,12 +49,13 @@
     private static final String USER_NOT_NULL = "User name cannot be null";
     private static final String KEY_NOT_NULL = "User key cannot be null";
     private static final String UTF_8 = "UTF-8";
-    private static final long TIMEOUT = 3;
 
     private static final String AUTHORIZED_KEYS = "authorized_keys";
 
+    private static final long TIMEOUT = 10; // 10 seconds
     private static final int MAX_MINUTES = 240; // 4 hours max
     private static final int MINUTE = 60_000; // 1 minute
+    private static final int DEFAULT_MINUTES = 60;
 
     private final File log = new File("warden.log");
 
@@ -153,7 +154,6 @@
     synchronized String borrowCell(String userName, String sshKey, int minutes) {
         checkNotNull(userName, USER_NOT_NULL);
         checkNotNull(sshKey, KEY_NOT_NULL);
-        checkArgument(minutes > 0, "Number of minutes must be positive");
         checkArgument(minutes < MAX_MINUTES, "Number of minutes must be less than %d", MAX_MINUTES);
         long now = System.currentTimeMillis();
         Reservation reservation = currentUserReservation(userName);
@@ -161,7 +161,10 @@
             Set<String> cells = getAvailableCells();
             checkState(!cells.isEmpty(), "No cells are presently available");
             String cellName = ImmutableList.copyOf(cells).get(random.nextInt(cells.size()));
-            reservation = new Reservation(cellName, userName, now, minutes);
+            reservation = new Reservation(cellName, userName, now, minutes == 0 ? DEFAULT_MINUTES : minutes);
+        } else if (minutes == 0) {
+            // If minutes are 0, simply return the cell definition
+            return getCellDefinition(reservation.cellName);
         } else {
             reservation = new Reservation(reservation.cellName, userName, now, minutes);
         }