Javadoc fixes
- fix missing Javadoc @param and @throw annotations
- enable checkstyle checks for method javadocs on non-private methods
Change-Id: I9a370419a699bab3225d85f2f641927600b9f11c
diff --git a/tools/build/conf/src/main/resources/onos/checkstyle.xml b/tools/build/conf/src/main/resources/onos/checkstyle.xml
index 78110c83d..5d81aa5 100644
--- a/tools/build/conf/src/main/resources/onos/checkstyle.xml
+++ b/tools/build/conf/src/main/resources/onos/checkstyle.xml
@@ -132,8 +132,10 @@
<!-- Checks for Javadoc comments. -->
<!-- See http://checkstyle.sf.net/config_javadoc.html -->
<module name="JavadocMethod">
- <property name="severity" value="warning"/>
+ <property name="scope" value="package"/>
+ <property name="allowMissingJavadoc" value="true"/>
<property name="allowUndeclaredRTE" value="true"/>
+ <property name="suppressLoadErrors" value="true"/>
</module>
<module name="JavadocType">
<property name="severity" value="warning"/>
diff --git a/tools/build/conf/src/main/resources/onos/suppressions.xml b/tools/build/conf/src/main/resources/onos/suppressions.xml
index 4af0d62..3c51c95 100644
--- a/tools/build/conf/src/main/resources/onos/suppressions.xml
+++ b/tools/build/conf/src/main/resources/onos/suppressions.xml
@@ -17,7 +17,6 @@
<!DOCTYPE suppressions PUBLIC "-//Puppy Crawl//DTD Suppressions 1.1//EN" "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
<suppressions>
-
<suppress files="org.apache.karaf.branding.*" checks="[a-zA-Z0-9]*"/>
<suppress files=".*" checks="FinalParametersCheck"/>
@@ -34,13 +33,13 @@
<suppress files="org.onosproject.segmentrouting.*" checks="AbbreviationAsWordInName" />
<!-- Suppressions for unit testing code -->
- <suppress checks="JavadocPackage"
+ <suppress checks="Javadoc.*"
files=".*/src/test/.*.java"
/>
- <suppress checks="JavadocPackage"
+ <suppress checks="Javadoc.*"
files=".*/thirdparty/.*.java"/>
<!-- Suppressions for yangutils generated code -->
- <suppress files="org.onosproject.yang.gen.v1.*" checks="JavadocStyle" />
+ <suppress files="org.onosproject.yang.gen.v1.*" checks="Javadoc.*" />
</suppressions>