Improve Executors related logging behavior
- Specify Logger for the Executor
- Use Executor#execute instead of ExecutorService#submit for
fire and forget type of usage.
Note: submit() will swallow thrown Exception
Change-Id: I507b841dc3feedf4ad20a746c304518d68fb846a
diff --git a/core/net/src/main/java/org/onosproject/net/device/impl/DeviceManager.java b/core/net/src/main/java/org/onosproject/net/device/impl/DeviceManager.java
index 60fd95a..5ef70fc 100644
--- a/core/net/src/main/java/org/onosproject/net/device/impl/DeviceManager.java
+++ b/core/net/src/main/java/org/onosproject/net/device/impl/DeviceManager.java
@@ -125,7 +125,8 @@
@Activate
public void activate() {
- backgroundService = newSingleThreadScheduledExecutor(groupedThreads("onos/device", "manager-background"));
+ backgroundService = newSingleThreadScheduledExecutor(
+ groupedThreads("onos/device", "manager-background", log));
localNodeId = clusterService.getLocalNode().id();
store.setDelegate(delegate);
@@ -499,7 +500,7 @@
deviceId, response, mastershipService.getLocalRole(deviceId));
// roleManager got the device to comply, but doesn't agree with
// the store; use the store's view, then try to reassert.
- backgroundService.submit(() -> reassertRole(deviceId, mastershipService.getLocalRole(deviceId)));
+ backgroundService.execute(() -> reassertRole(deviceId, mastershipService.getLocalRole(deviceId)));
return;
}
} else {
@@ -684,7 +685,7 @@
@Override
public void event(MastershipEvent event) {
- backgroundService.submit(() -> {
+ backgroundService.execute(() -> {
try {
handleMastershipEvent(event);
} catch (Exception e) {