Cosmetic fixes and logging around Juniper driver
Change-Id: Ief0dba3a1c4cc567cf9fe6fa16b4aeae9488c51e
diff --git a/drivers/juniper/src/main/java/org/onosproject/drivers/juniper/JuniperUtils.java b/drivers/juniper/src/main/java/org/onosproject/drivers/juniper/JuniperUtils.java
index 76f5f3b..efd5f50 100644
--- a/drivers/juniper/src/main/java/org/onosproject/drivers/juniper/JuniperUtils.java
+++ b/drivers/juniper/src/main/java/org/onosproject/drivers/juniper/JuniperUtils.java
@@ -33,6 +33,7 @@
import org.onosproject.net.device.PortDescription;
import org.onosproject.net.link.DefaultLinkDescription;
import org.onosproject.net.link.LinkDescription;
+import org.slf4j.Logger;
import java.util.HashSet;
import java.util.List;
@@ -45,6 +46,7 @@
import static org.onosproject.net.Device.Type.ROUTER;
import static org.onosproject.net.Port.Type.COPPER;
import static org.onosproject.net.PortNumber.portNumber;
+import static org.slf4j.LoggerFactory.getLogger;
/**
* Utility class for Netconf XML for Juniper.
@@ -52,6 +54,8 @@
*/
public final class JuniperUtils {
+ private static final Logger log = getLogger(JuniperUtils.class);
+
public static final String FAILED_CFG = "Failed to retrieve configuration.";
private static final String RPC_TAG_NETCONF_BASE = "<rpc xmlns=\"urn:ietf:params:xml:ns:netconf:base:1.0\">";
@@ -173,6 +177,9 @@
if (interf.getString(IF_TYPE).contains(ETH) &&
interf.getString(SPEED).contains(MBPS)) {
portDescriptions.add(parseDefaultPort(interf));
+ } else {
+ log.debug("Ignoring default port candidate {}",
+ interf.getString(NAME));
}
} else if (interf.getString(IF_LO_ENCAP) != null &&
!interf.getString(NAME).contains("pfe") &&
@@ -180,6 +187,9 @@
portDescriptions.add(parseLogicalPort(interf));
} else if (interf.getString(NAME).contains("lo")) {
portDescriptions.add(parseLoopback(interf));
+ } else {
+ log.debug("Ignoring unknown port {}",
+ interf.getString(NAME));
}
}
}