commit | 5f71b41a73eedbdb0060e451eadb5d3e008adc4d | [log] [tgz] |
---|---|---|
author | Andreas Wundsam <andreas.wundsam@bigswitch.com> | Tue Feb 18 12:56:35 2014 -0800 |
committer | Andreas Wundsam <andreas.wundsam@bigswitch.com> | Tue Feb 18 12:56:35 2014 -0800 |
tree | bd4ebcdbb8d411e2b7a1ae5c8e6665878eb74e59 | |
parent | 4e2469e31d47c8a54b83a630482009f481d0e0e7 [diff] [blame] |
java_gen: use Arrays.copyOf() instead of .clone() for defensive copy @gregor-bsn convinced me it's better :)
diff --git a/java_gen/pre-written/src/main/java/org/projectfloodlight/openflow/types/IPv4Address.java b/java_gen/pre-written/src/main/java/org/projectfloodlight/openflow/types/IPv4Address.java index 73b1a7d..43a7a17 100644 --- a/java_gen/pre-written/src/main/java/org/projectfloodlight/openflow/types/IPv4Address.java +++ b/java_gen/pre-written/src/main/java/org/projectfloodlight/openflow/types/IPv4Address.java
@@ -1,5 +1,7 @@ package org.projectfloodlight.openflow.types; +import java.util.Arrays; + import org.jboss.netty.buffer.ChannelBuffer; import com.google.common.hash.PrimitiveSink; @@ -133,7 +135,7 @@ } } } - return bytesCache.clone(); + return Arrays.copyOf(bytesCache, bytesCache.length); } @Override