tree 4cb5b79b1d01854684a9be76a51f91ea735244e7
parent b34bd717880b534e70172081e5b5a94ee629dd43
author Andreas Wundsam <andreas.wundsam@bigswitch.com> 1415840513 -0800
committer Andreas Wundsam <andreas.wundsam@bigswitch.com> 1415840513 -0800

java_gen/GenericReader: BUGFIX version dispatch for hybrid

This commit fixes a bug in OpenFlowJ's GenericReader. GenericReader
previously dispatched to the version specific readers based on
bb.getByte(0). This turns out to be the first *absolute* byte in the
ChannelBuffer, not the first readable byte at the current readerIndex.

I.e., if several messages were queued in the ChannelBuffer, the Generic
Reader would always dispatch according to the version of the first
message.

In standard use, we pin the OF version after we receive the HELLO
from the switch. Hence, this was not a problem observed in practice.

It could cause problems for hybrid mode connections.