commit 33d33e08b80e3e9f5a4de8f61c6423a77fb4210f
author Andreas Wundsam <andreas.wundsam@bigswitch.com> Tue Jul 01 08:09:22 2014 -0700
committer Andreas Wundsam <andreas.wundsam@bigswitch.com> Tue Jul 01 08:10:43 2014 -0700
tree 64ad2cf7a5bbc8f19392d48e6e08d174de37361b
parent c2775200bf595fd9d824506b4d56fbb3aff1f6e3

U128.add(): optimize overflow comparison

It is enough to just compare one of the operands to check for
overflow -- in the case of overflow, the result is guaranteed
to be smaller than either one.

java_gen/pre-written/src/main/java/org/projectfloodlight/openflow/types/U128.java

diff --git a/java_gen/pre-written/src/main/java/org/projectfloodlight/openflow/types/U128.java b/java_gen/pre-written/src/main/java/org/projectfloodlight/openflow/types/U128.java
index ba7d88a..0b4e0f7 100644
--- a/java_gen/pre-written/src/main/java/org/projectfloodlight/openflow/types/U128.java
+++ b/java_gen/pre-written/src/main/java/org/projectfloodlight/openflow/types/U128.java
@@ -126,8 +126,7 @@
     public U128 add(U128 other) {
         long newRaw2 = this.raw2 + other.raw2;
         long newRaw1 = this.raw1 + other.raw1;
-        if (UnsignedLongs.compare(newRaw2, this.raw2) < 0 ||
-            UnsignedLongs.compare(newRaw2, other.raw2) < 0) {
+        if(UnsignedLongs.compare(newRaw2, this.raw2) < 0) {
             // raw2 overflow
             newRaw1+=1;
         }
@@ -138,7 +137,7 @@
     public U128 subtract(U128 other) {
         long newRaw2 = this.raw2 - other.raw2;
         long newRaw1 = this.raw1 - other.raw1;
-        if (UnsignedLongs.compare(this.raw2, other.raw2) < 0) {
+        if(UnsignedLongs.compare(this.raw2, other.raw2) < 0) {
             newRaw1 -= 1;
         }
         return U128.of(newRaw1, newRaw2);