java_gen: Add documentation on OFPortBitmap, unit test clarity fix
Limit the unit test use the to 127 (valid) ports for clarity.
diff --git a/java_gen/pre-written/src/test/java/org/projectfloodlight/openflow/types/OFPortBitMapTest.java b/java_gen/pre-written/src/test/java/org/projectfloodlight/openflow/types/OFPortBitMapTest.java
index b18d0eb..7f5ab5d 100644
--- a/java_gen/pre-written/src/test/java/org/projectfloodlight/openflow/types/OFPortBitMapTest.java
+++ b/java_gen/pre-written/src/test/java/org/projectfloodlight/openflow/types/OFPortBitMapTest.java
@@ -9,14 +9,14 @@
@Test
public void testOFPortBitMap() {
- Boolean[] on = new Boolean[128];
- for (int i = 0; i < 128; i++) {
+ Boolean[] on = new Boolean[127];
+ for (int i = 0; i < 127; i++) {
on[i] = false;
}
OFPortBitMap.Builder builder = new OFPortBitMap.Builder();
- for (int i = 0; i < 128; i += 3) {
+ for (int i = 0; i < 127; i += 3) {
OFPort p = OFPort.of(i);
builder.set(p);
on[p.getPortNumber()] = true;
@@ -25,28 +25,28 @@
// Test that all ports that were added are actually on, and all other ports are off
OFPortBitMap portmap = builder.build();
//System.out.println(portmap);
- Boolean[] actual = new Boolean[128];
- for (int i = 0; i < 128; i++) {
+ Boolean[] actual = new Boolean[127];
+ for (int i = 0; i < 127; i++) {
actual[i] = false;
}
- for (int i = 0; i < 128; i++) {
+ for (int i = 0; i < 127; i++) {
actual[i] = portmap.isOn(OFPort.of(i));
}
assertArrayEquals(on, actual);
// Turn some ports off
- for (int i = 0; i < 128; i += 7) {
+ for (int i = 0; i < 127; i += 7) {
on[i] = false;
builder.unset(OFPort.of(i));
}
// Test again
portmap = builder.build();
- actual = new Boolean[128];
- for (int i = 0; i < 128; i++) {
+ actual = new Boolean[127];
+ for (int i = 0; i < 127; i++) {
actual[i] = false;
}
- for (int i = 0; i < 128; i++) {
+ for (int i = 0; i < 127; i++) {
actual[i] = portmap.isOn(OFPort.of(i));
}
assertArrayEquals(on, actual);